Re: [PATCH v6 1/5] perf/jevents: Remove jevents.h file

2020-09-02 Thread John Garry
On 01/09/2020 06:56, kajoljain wrote: +#define min(x, y) ({    \ +    typeof(x) _min1 = (x);    \ +    typeof(y) _min2 = (y);    \ +    (void)(&_min1 == &_min2);    \ +    _min1 < _min2 ? _min1 : _min2; }) +#endif Wondering what is special about this definition

Re: [PATCH v6 1/5] perf/jevents: Remove jevents.h file

2020-08-31 Thread kajoljain
On 8/31/20 2:31 PM, John Garry wrote: > On 31/08/2020 09:43, Jiri Olsa wrote: >> On Thu, Aug 27, 2020 at 06:39:54PM +0530, Kajol Jain wrote: >>> This patch removes jevents.h file and add its data inside >>> jevents.c as this file is only included there. >>> >>> Signed-off-by: Kajol Jain >>>

Re: [PATCH v6 1/5] perf/jevents: Remove jevents.h file

2020-08-31 Thread kajoljain
On 8/31/20 2:13 PM, Jiri Olsa wrote: > On Thu, Aug 27, 2020 at 06:39:54PM +0530, Kajol Jain wrote: >> This patch removes jevents.h file and add its data inside >> jevents.c as this file is only included there. >> >> Signed-off-by: Kajol Jain >> --- >> tools/perf/pmu-events/jevents.c | 9

Re: [PATCH v6 1/5] perf/jevents: Remove jevents.h file

2020-08-31 Thread John Garry
On 31/08/2020 09:43, Jiri Olsa wrote: On Thu, Aug 27, 2020 at 06:39:54PM +0530, Kajol Jain wrote: This patch removes jevents.h file and add its data inside jevents.c as this file is only included there. Signed-off-by: Kajol Jain --- tools/perf/pmu-events/jevents.c | 9 -

Re: [PATCH v6 1/5] perf/jevents: Remove jevents.h file

2020-08-31 Thread Jiri Olsa
On Thu, Aug 27, 2020 at 06:39:54PM +0530, Kajol Jain wrote: > This patch removes jevents.h file and add its data inside > jevents.c as this file is only included there. > > Signed-off-by: Kajol Jain > --- > tools/perf/pmu-events/jevents.c | 9 - > tools/perf/pmu-events/jevents.h | 23

[PATCH v6 1/5] perf/jevents: Remove jevents.h file

2020-08-27 Thread Kajol Jain
This patch removes jevents.h file and add its data inside jevents.c as this file is only included there. Signed-off-by: Kajol Jain --- tools/perf/pmu-events/jevents.c | 9 - tools/perf/pmu-events/jevents.h | 23 --- 2 files changed, 8 insertions(+), 24 deletions(-)