RE: [PATCH v6 1/5] spi: spi-mem: Add driver for NXP FlexSPI controller

2019-01-15 Thread Yogesh Narayan Gaur
t; broo...@kernel.org; linux-...@vger.kernel.org; devicet...@vger.kernel.org; > mark.rutl...@arm.com; r...@kernel.org; linux-kernel@vger.kernel.org; > computersforpe...@gmail.com; shawn...@kernel.org; linux-arm- > ker...@lists.infradead.org > Subject: Re: [PATCH v6 1/5] spi: sp

Re: [PATCH v6 1/5] spi: spi-mem: Add driver for NXP FlexSPI controller

2019-01-14 Thread Boris Brezillon
On Thu, 10 Jan 2019 17:28:57 + Schrempf Frieder wrote: > Hi Yogesh, > > my comments below are mainly about things I already mentioned in my > review for v5 and about removing or simplifying some unnecessary or > complex code. > > Also as I gathered from your conversation with Boris,

Re: [PATCH v6 1/5] spi: spi-mem: Add driver for NXP FlexSPI controller

2019-01-10 Thread Schrempf Frieder
Hi Yogesh, my comments below are mainly about things I already mentioned in my review for v5 and about removing or simplifying some unnecessary or complex code. Also as I gathered from your conversation with Boris, there's still a check for the length of the requested memory missing. On

[PATCH v6 1/5] spi: spi-mem: Add driver for NXP FlexSPI controller

2019-01-08 Thread Yogesh Narayan Gaur
- Add driver for NXP FlexSPI host controller (0) What is the FlexSPI controller? FlexSPI is a flexsible SPI host controller which supports two SPI channels and up to 4 external devices. Each channel supports Single/Dual/Quad/Octal mode data transfer (1/2/4/8 bidirectional data lines) i.e.