Re: [PATCH v6 10/17] x86/static_call: Add inline static call implementation for x86-64

2020-07-11 Thread Peter Zijlstra
On Fri, Jul 10, 2020 at 06:31:55PM -0400, Steven Rostedt wrote: > On Fri, 10 Jul 2020 15:38:41 +0200 > Peter Zijlstra wrote: > > + /* find key symbol */ > > + key_name = strdup(insn->call_dest->name); > > Should check for failed allocation of strdup(). Rigt, I'll go add the

Re: [PATCH v6 10/17] x86/static_call: Add inline static call implementation for x86-64

2020-07-10 Thread Steven Rostedt
On Fri, 10 Jul 2020 15:38:41 +0200 Peter Zijlstra wrote: > --- a/tools/objtool/check.c > +++ b/tools/objtool/check.c > @@ -16,6 +16,7 @@ > > #include > #include > +#include > > #define FAKE_JUMP_OFFSET -1 > > @@ -433,6 +434,99 @@ static int add_dead_ends(struct objtool_ > return

[PATCH v6 10/17] x86/static_call: Add inline static call implementation for x86-64

2020-07-10 Thread Peter Zijlstra
From: Josh Poimboeuf Add the inline static call implementation for x86-64. The generated code is identical to the out-of-line case, except we move the trampoline into it's own section. Objtool uses the trampoline naming convention to detect all the call sites. It then annotates those call sites