Re: [PATCH v6 11/11] pwm: Add Raspberry Pi Firmware based PWM bus

2021-01-14 Thread Nicolas Saenz Julienne
Hi Uwe, thanks for the review. On Tue, 2021-01-12 at 10:18 +0100, Uwe Kleine-König wrote: [...] > > +duty_cycle = DIV_ROUND_CLOSEST_ULL(state->duty_cycle * > > RPI_PWM_MAX_DUTY, > > + RPI_PWM_PERIOD_NS); > > ... and round down here.

Re: [PATCH v6 11/11] pwm: Add Raspberry Pi Firmware based PWM bus

2021-01-12 Thread Uwe Kleine-König
Hello Nicolas, On Fri, Dec 11, 2020 at 05:48:00PM +0100, Nicolas Saenz Julienne wrote: > diff --git a/drivers/pwm/pwm-raspberrypi-poe.c > b/drivers/pwm/pwm-raspberrypi-poe.c > new file mode 100644 > index ..24b498839fcc > --- /dev/null > +++ b/drivers/pwm/pwm-raspberrypi-poe.c > @@

[PATCH v6 11/11] pwm: Add Raspberry Pi Firmware based PWM bus

2020-12-11 Thread Nicolas Saenz Julienne
Adds support to control the PWM bus available in official Raspberry Pi PoE HAT. Only RPi's co-processor has access to it, so commands have to be sent through RPi's firmware mailbox interface. Signed-off-by: Nicolas Saenz Julienne --- Changes since v3: - Rename compatible string to be more