Re: [PATCH v6 13/13] block: Only clone bio vecs that are in use

Hello, Kent. On Fri, Aug 24, 2012 at 12:05:08AM -0700, Kent Overstreet wrote: > > I'm pretty sure I sound like a broken record by now, but > > > > * How was this tested? > > > > * What are the implications and possible dangers? > > I've said all that on list, but I gather what you really wanted

Re: [PATCH v6 13/13] block: Only clone bio vecs that are in use

On Wed, Aug 22, 2012 at 02:10:45PM -0700, Tejun Heo wrote: > Hello, Kent. > > On Wed, Aug 22, 2012 at 10:04:10AM -0700, Kent Overstreet wrote: > > bcache creates large bios internally, and then splits them according to > > the device requirements before it sends them down. If a lower level > > dev

Re: [PATCH v6 13/13] block: Only clone bio vecs that are in use

Hello, Kent. On Wed, Aug 22, 2012 at 10:04:10AM -0700, Kent Overstreet wrote: > bcache creates large bios internally, and then splits them according to > the device requirements before it sends them down. If a lower level > device tries to clone the bio, and the original bio had more than > BIO_MA

[PATCH v6 13/13] block: Only clone bio vecs that are in use

bcache creates large bios internally, and then splits them according to the device requirements before it sends them down. If a lower level device tries to clone the bio, and the original bio had more than BIO_MAX_PAGES, the clone will fail unecessarily. We can fix this by only cloning the bio vec