> >
> > >
> > > That said, I wonder whether we even care about a merge in the right
> > > shift case since we haven't punched a hole in the file and thus have not
> > > changed the "neighbors" of any of the extents we're shuffling around. I
> > > would think any extents that are already contiguous
On Thu, Dec 04, 2014 at 08:19:50PM +0900, Namjae Jeon wrote:
> >
> > Hi Namjae,
> Hi Brian,
>
> >
> > Here are some review notes. I haven't got to any of the test code or
> > played around with it just yet...
> Thanks for your reivew :)
>
No problem. :)
> > >
> > > diff --git
>
> Hi Namjae,
Hi Brian,
>
> Here are some review notes. I haven't got to any of the test code or
> played around with it just yet...
Thanks for your reivew :)
> >
> > diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
> > index 79c9819..da01890 100644
> > ---
Hi Namjae,
Hi Brian,
Here are some review notes. I haven't got to any of the test code or
played around with it just yet...
Thanks for your reivew :)
diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
index 79c9819..da01890 100644
--- a/fs/xfs/libxfs/xfs_bmap.c
+++
On Thu, Dec 04, 2014 at 08:19:50PM +0900, Namjae Jeon wrote:
Hi Namjae,
Hi Brian,
Here are some review notes. I haven't got to any of the test code or
played around with it just yet...
Thanks for your reivew :)
No problem. :)
diff --git a/fs/xfs/libxfs/xfs_bmap.c
That said, I wonder whether we even care about a merge in the right
shift case since we haven't punched a hole in the file and thus have not
changed the neighbors of any of the extents we're shuffling around. I
would think any extents that are already contiguous as such are
On Mon, Nov 24, 2014 at 03:16:33PM +0900, Namjae Jeon wrote:
> This patch implements fallocate's FALLOC_FL_INSERT_RANGE for XFS.
>
> 1) Make sure that both offset and len are block size aligned.
> 2) Update the i_size of inode by len bytes.
> 3) Compute the file's logical block number against
On Mon, Nov 24, 2014 at 03:16:33PM +0900, Namjae Jeon wrote:
This patch implements fallocate's FALLOC_FL_INSERT_RANGE for XFS.
1) Make sure that both offset and len are block size aligned.
2) Update the i_size of inode by len bytes.
3) Compute the file's logical block number against offset.
This patch implements fallocate's FALLOC_FL_INSERT_RANGE for XFS.
1) Make sure that both offset and len are block size aligned.
2) Update the i_size of inode by len bytes.
3) Compute the file's logical block number against offset. If the computed
block number is not the starting block of the
This patch implements fallocate's FALLOC_FL_INSERT_RANGE for XFS.
1) Make sure that both offset and len are block size aligned.
2) Update the i_size of inode by len bytes.
3) Compute the file's logical block number against offset. If the computed
block number is not the starting block of the
10 matches
Mail list logo
