Re: [PATCH v6 2/2] acpi: apei: Do not panic() on PCIe errors reported through GHES

On 05/22/2018 10:15 AM, Tyler Baicar wrote: > On 5/22/2018 10:32 AM, Alex G. wrote: >> I think the biggest problem is having a policy to panic on "fatal" >> errors, instead of letting the error handler make that decision. I'd >> much rather kill that stupid policy, but people seem to like it for

Re: [PATCH v6 2/2] acpi: apei: Do not panic() on PCIe errors reported through GHES

On 05/22/2018 10:15 AM, Tyler Baicar wrote: > On 5/22/2018 10:32 AM, Alex G. wrote: >> I think the biggest problem is having a policy to panic on "fatal" >> errors, instead of letting the error handler make that decision. I'd >> much rather kill that stupid policy, but people seem to like it for

Re: [PATCH v6 2/2] acpi: apei: Do not panic() on PCIe errors reported through GHES

On 5/22/2018 10:32 AM, Alex G. wrote: I think the biggest problem is having a policy to panic on "fatal" errors, instead of letting the error handler make that decision. I'd much rather kill that stupid policy, but people seem to like it for some reason. You can get around that panic and still

Re: [PATCH v6 2/2] acpi: apei: Do not panic() on PCIe errors reported through GHES

On 5/22/2018 10:32 AM, Alex G. wrote: I think the biggest problem is having a policy to panic on "fatal" errors, instead of letting the error handler make that decision. I'd much rather kill that stupid policy, but people seem to like it for some reason. You can get around that panic and still

Re: [PATCH v6 2/2] acpi: apei: Do not panic() on PCIe errors reported through GHES

On 05/22/2018 04:02 AM, Rafael J. Wysocki wrote: > On Mon, May 21, 2018 at 3:49 PM, Alexandru Gagniuc > wrote: >> The policy was to panic() when GHES said that an error is "Fatal". >> This logic is wrong for several reasons, as it doesn't account for the >> cause of the

Re: [PATCH v6 2/2] acpi: apei: Do not panic() on PCIe errors reported through GHES

On 05/22/2018 04:02 AM, Rafael J. Wysocki wrote: > On Mon, May 21, 2018 at 3:49 PM, Alexandru Gagniuc > wrote: >> The policy was to panic() when GHES said that an error is "Fatal". >> This logic is wrong for several reasons, as it doesn't account for the >> cause of the error. >> >> PCIe fatal

Re: [PATCH v6 2/2] acpi: apei: Do not panic() on PCIe errors reported through GHES

On Mon, May 21, 2018 at 3:49 PM, Alexandru Gagniuc wrote: > The policy was to panic() when GHES said that an error is "Fatal". > This logic is wrong for several reasons, as it doesn't account for the > cause of the error. > > PCIe fatal errors indicate that the link to a

Re: [PATCH v6 2/2] acpi: apei: Do not panic() on PCIe errors reported through GHES

On Mon, May 21, 2018 at 3:49 PM, Alexandru Gagniuc wrote: > The policy was to panic() when GHES said that an error is "Fatal". > This logic is wrong for several reasons, as it doesn't account for the > cause of the error. > > PCIe fatal errors indicate that the link to a device is either >

Re: [PATCH v6 2/2] acpi: apei: Do not panic() on PCIe errors reported through GHES

On 05/21/2018 09:27 AM, Tyler Baicar wrote: > On 5/21/2018 9:49 AM, Alexandru Gagniuc wrote: (snip) > Hello Alex, > > There is a compile warning if CONFIG_HAVE_ACPI_APEI_NMI is not selected. > >   CC  drivers/acpi/apei/ghes.o > drivers/acpi/apei/ghes.c:483:12: warning: ‘ghes_severity’

Re: [PATCH v6 2/2] acpi: apei: Do not panic() on PCIe errors reported through GHES

On 05/21/2018 09:27 AM, Tyler Baicar wrote: > On 5/21/2018 9:49 AM, Alexandru Gagniuc wrote: (snip) > Hello Alex, > > There is a compile warning if CONFIG_HAVE_ACPI_APEI_NMI is not selected. > >   CC  drivers/acpi/apei/ghes.o > drivers/acpi/apei/ghes.c:483:12: warning: ‘ghes_severity’

Re: [PATCH v6 2/2] acpi: apei: Do not panic() on PCIe errors reported through GHES

On 5/21/2018 9:49 AM, Alexandru Gagniuc wrote: +/* PCIe errors should not cause a panic. */ +static int ghes_sec_pcie_severity(struct acpi_hest_generic_data *gdata) +{ + struct cper_sec_pcie *pcie_err = acpi_hest_get_payload(gdata); + + if (pcie_err->validation_bits &

Re: [PATCH v6 2/2] acpi: apei: Do not panic() on PCIe errors reported through GHES

On 5/21/2018 9:49 AM, Alexandru Gagniuc wrote: +/* PCIe errors should not cause a panic. */ +static int ghes_sec_pcie_severity(struct acpi_hest_generic_data *gdata) +{ + struct cper_sec_pcie *pcie_err = acpi_hest_get_payload(gdata); + + if (pcie_err->validation_bits &

[PATCH v6 2/2] acpi: apei: Do not panic() on PCIe errors reported through GHES

The policy was to panic() when GHES said that an error is "Fatal". This logic is wrong for several reasons, as it doesn't account for the cause of the error. PCIe fatal errors indicate that the link to a device is either unstable or unusable. They don't indicate that the machine is on fire, and

[PATCH v6 2/2] acpi: apei: Do not panic() on PCIe errors reported through GHES

The policy was to panic() when GHES said that an error is "Fatal". This logic is wrong for several reasons, as it doesn't account for the cause of the error. PCIe fatal errors indicate that the link to a device is either unstable or unusable. They don't indicate that the machine is on fire, and