Re: [PATCH v6 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-21 Thread Heiko Stübner
Hi Frank, Am Dienstag, 21. Juni 2016, 15:52:45 schrieb Frank Wang: > On 2016/6/20 12:56, Guenter Roeck wrote: > > On Sun, Jun 19, 2016 at 8:32 PM, Frank Wang wrote: > >>> Turns out my problem was one of terminology. Using "suspend" and > >>> "resume" to me suggested the common use of suspend and

Re: [PATCH v6 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-21 Thread Frank Wang
Hi Heiko, On 2016/6/21 17:05, Heiko Stübner wrote: Hi Frank, Am Dienstag, 21. Juni 2016, 15:52:45 schrieb Frank Wang: On 2016/6/20 12:56, Guenter Roeck wrote: On Sun, Jun 19, 2016 at 8:32 PM, Frank Wang wrote: Turns out my problem was one of terminology. Using "suspend" and "resume" to me

Re: [PATCH v6 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-21 Thread Frank Wang
Hi Heiko, On 2016/6/20 12:56, Guenter Roeck wrote: Hi Frank, On Sun, Jun 19, 2016 at 8:32 PM, Frank Wang wrote: Hi Heiko & Guenter, On 2016/6/20 11:00, Guenter Roeck wrote: On Sun, Jun 19, 2016 at 6:27 PM, Frank Wang wrote: Hi Guenter, On 2016/6/17 21:20, Guenter Roeck wrote: Hi Frank

Re: [PATCH v6 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-19 Thread Guenter Roeck
Hi Frank, On Sun, Jun 19, 2016 at 8:32 PM, Frank Wang wrote: > Hi Heiko & Guenter, > > > On 2016/6/20 11:00, Guenter Roeck wrote: >> >> On Sun, Jun 19, 2016 at 6:27 PM, Frank Wang >> wrote: >>> >>> Hi Guenter, >>> >>> >>> On 2016/6/17 21:20, Guenter Roeck wrote: Hi Frank, On

Re: [PATCH v6 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-19 Thread Frank Wang
Hi Heiko & Guenter, On 2016/6/20 11:00, Guenter Roeck wrote: On Sun, Jun 19, 2016 at 6:27 PM, Frank Wang wrote: Hi Guenter, On 2016/6/17 21:20, Guenter Roeck wrote: Hi Frank, On 06/16/2016 11:43 PM, Frank Wang wrote: Hi Guenter, On 2016/6/17 12:59, Guenter Roeck wrote: On 06/16/2016 07:

Re: [PATCH v6 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-19 Thread Guenter Roeck
On Sun, Jun 19, 2016 at 6:27 PM, Frank Wang wrote: > Hi Guenter, > > > On 2016/6/17 21:20, Guenter Roeck wrote: >> >> Hi Frank, >> >> On 06/16/2016 11:43 PM, Frank Wang wrote: >>> >>> Hi Guenter, >>> >>> On 2016/6/17 12:59, Guenter Roeck wrote: On 06/16/2016 07:09 PM, Frank Wang wrote: >

Re: [PATCH v6 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-19 Thread Frank Wang
Hi Guenter, On 2016/6/17 21:20, Guenter Roeck wrote: Hi Frank, On 06/16/2016 11:43 PM, Frank Wang wrote: Hi Guenter, On 2016/6/17 12:59, Guenter Roeck wrote: On 06/16/2016 07:09 PM, Frank Wang wrote: The newer SoCs (rk3366, rk3399) take a different usb-phy IP block than rk3288 and before, a

Re: [PATCH v6 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-17 Thread Guenter Roeck
Hi Frank, On 06/16/2016 11:43 PM, Frank Wang wrote: Hi Guenter, On 2016/6/17 12:59, Guenter Roeck wrote: On 06/16/2016 07:09 PM, Frank Wang wrote: The newer SoCs (rk3366, rk3399) take a different usb-phy IP block than rk3288 and before, and most of phy-related registers are also different fro

Re: [PATCH v6 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-16 Thread Frank Wang
Hi Guenter, On 2016/6/17 12:59, Guenter Roeck wrote: On 06/16/2016 07:09 PM, Frank Wang wrote: The newer SoCs (rk3366, rk3399) take a different usb-phy IP block than rk3288 and before, and most of phy-related registers are also different from the past, so a new phy driver is required necessaril

Re: [PATCH v6 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-16 Thread Guenter Roeck
On 06/16/2016 07:09 PM, Frank Wang wrote: The newer SoCs (rk3366, rk3399) take a different usb-phy IP block than rk3288 and before, and most of phy-related registers are also different from the past, so a new phy driver is required necessarily. Signed-off-by: Frank Wang Suggested-by: Guenter Ro

[PATCH v6 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy

2016-06-16 Thread Frank Wang
The newer SoCs (rk3366, rk3399) take a different usb-phy IP block than rk3288 and before, and most of phy-related registers are also different from the past, so a new phy driver is required necessarily. Signed-off-by: Frank Wang Suggested-by: Guenter Roeck Suggested-by: Doug Anderson Reviewed-b