Re: [PATCH v6 2/4] power: reset: add reboot mode driver

2016-06-21 Thread Krzysztof Kozlowski
On 06/21/2016 01:01 PM, Andy Yan wrote: (...) >>> +MODULE_AUTHOR("Andy Yan >> +MODULE_DESCRIPTION("System reboot mode driver"); >>> +MODULE_LICENSE("GPL v2"); >>> diff --git a/drivers/power/reset/reboot-mode.h >>> b/drivers/power/reset/reboot-mode.h >>> new file mode

Re: [PATCH v6 2/4] power: reset: add reboot mode driver

2016-06-21 Thread Krzysztof Kozlowski
On 06/21/2016 01:01 PM, Andy Yan wrote: (...) >>> +MODULE_AUTHOR("Andy Yan >> +MODULE_DESCRIPTION("System reboot mode driver"); >>> +MODULE_LICENSE("GPL v2"); >>> diff --git a/drivers/power/reset/reboot-mode.h >>> b/drivers/power/reset/reboot-mode.h >>> new file mode 100644 >>> index

Re: [PATCH v6 2/4] power: reset: add reboot mode driver

2016-06-21 Thread Andy Yan
Hi Krzysztof: On 2016年03月24日 10:50, Krzysztof Kozlowski wrote: Cool work! Few comments below. On Tue, Mar 22, 2016 at 8:37 PM, Andy Yan wrote: This driver parse the reboot commands like "reboot loader" and "reboot recovery" to get a boot mode described in the

Re: [PATCH v6 2/4] power: reset: add reboot mode driver

2016-06-21 Thread Andy Yan
Hi Krzysztof: On 2016年03月24日 10:50, Krzysztof Kozlowski wrote: Cool work! Few comments below. On Tue, Mar 22, 2016 at 8:37 PM, Andy Yan wrote: This driver parse the reboot commands like "reboot loader" and "reboot recovery" to get a boot mode described in the device tree , then call the

Re: [PATCH v6 2/4] power: reset: add reboot mode driver

2016-03-28 Thread Krzysztof Kozlowski
On 28.03.2016 16:40, Andy Yan wrote: > Hi Krzysztof : > > On 2016年03月28日 14:34, Krzysztof Kozlowski wrote: >> On 24.03.2016 17:03, Andy Yan wrote: >>> Hi Krzystof: >> (...) >> > +static int get_reboot_mode_magic(struct reboot_mode_driver *reboot, > +const

Re: [PATCH v6 2/4] power: reset: add reboot mode driver

2016-03-28 Thread Krzysztof Kozlowski
On 28.03.2016 16:40, Andy Yan wrote: > Hi Krzysztof : > > On 2016年03月28日 14:34, Krzysztof Kozlowski wrote: >> On 24.03.2016 17:03, Andy Yan wrote: >>> Hi Krzystof: >> (...) >> > +static int get_reboot_mode_magic(struct reboot_mode_driver *reboot, > +const

Re: [PATCH v6 2/4] power: reset: add reboot mode driver

2016-03-28 Thread Andy Yan
Hi Krzysztof : On 2016年03月28日 14:34, Krzysztof Kozlowski wrote: On 24.03.2016 17:03, Andy Yan wrote: Hi Krzystof: (...) +static int get_reboot_mode_magic(struct reboot_mode_driver *reboot, +const char *cmd) +{ + const char *normal = "normal"; +

Re: [PATCH v6 2/4] power: reset: add reboot mode driver

2016-03-28 Thread Andy Yan
Hi Krzysztof : On 2016年03月28日 14:34, Krzysztof Kozlowski wrote: On 24.03.2016 17:03, Andy Yan wrote: Hi Krzystof: (...) +static int get_reboot_mode_magic(struct reboot_mode_driver *reboot, +const char *cmd) +{ + const char *normal = "normal"; +

Re: [PATCH v6 2/4] power: reset: add reboot mode driver

2016-03-28 Thread Krzysztof Kozlowski
On 24.03.2016 17:03, Andy Yan wrote: > Hi Krzystof: (...) >>> +static int get_reboot_mode_magic(struct reboot_mode_driver *reboot, >>> +const char *cmd) >>> +{ >>> + const char *normal = "normal"; >>> + int magic = 0; >>> + struct mode_info

Re: [PATCH v6 2/4] power: reset: add reboot mode driver

2016-03-28 Thread Krzysztof Kozlowski
On 24.03.2016 17:03, Andy Yan wrote: > Hi Krzystof: (...) >>> +static int get_reboot_mode_magic(struct reboot_mode_driver *reboot, >>> +const char *cmd) >>> +{ >>> + const char *normal = "normal"; >>> + int magic = 0; >>> + struct mode_info

Re: [PATCH v6 2/4] power: reset: add reboot mode driver

2016-03-24 Thread Andy Yan
Hi Krzystof: On 2016年03月24日 10:50, Krzysztof Kozlowski wrote: Cool work! Few comments below. On Tue, Mar 22, 2016 at 8:37 PM, Andy Yan wrote: This driver parse the reboot commands like "reboot loader" and "reboot recovery" to get a boot mode described in the device

Re: [PATCH v6 2/4] power: reset: add reboot mode driver

2016-03-24 Thread Andy Yan
Hi Krzystof: On 2016年03月24日 10:50, Krzysztof Kozlowski wrote: Cool work! Few comments below. On Tue, Mar 22, 2016 at 8:37 PM, Andy Yan wrote: This driver parse the reboot commands like "reboot loader" and "reboot recovery" to get a boot mode described in the device tree , then call the

Re: [PATCH v6 2/4] power: reset: add reboot mode driver

2016-03-23 Thread Krzysztof Kozlowski
Cool work! Few comments below. On Tue, Mar 22, 2016 at 8:37 PM, Andy Yan wrote: > This driver parse the reboot commands like "reboot loader" > and "reboot recovery" to get a boot mode described in the > device tree , then call the write interfae to store the boot > mode

Re: [PATCH v6 2/4] power: reset: add reboot mode driver

2016-03-23 Thread Krzysztof Kozlowski
Cool work! Few comments below. On Tue, Mar 22, 2016 at 8:37 PM, Andy Yan wrote: > This driver parse the reboot commands like "reboot loader" > and "reboot recovery" to get a boot mode described in the > device tree , then call the write interfae to store the boot > mode in some place like

[PATCH v6 2/4] power: reset: add reboot mode driver

2016-03-22 Thread Andy Yan
This driver parse the reboot commands like "reboot loader" and "reboot recovery" to get a boot mode described in the device tree , then call the write interfae to store the boot mode in some place like special register or sram , which can be read by the bootloader after system reboot, then the

[PATCH v6 2/4] power: reset: add reboot mode driver

2016-03-22 Thread Andy Yan
This driver parse the reboot commands like "reboot loader" and "reboot recovery" to get a boot mode described in the device tree , then call the write interfae to store the boot mode in some place like special register or sram , which can be read by the bootloader after system reboot, then the