Re: [PATCH v6 2/5] MFD: RK808: Add new mfd driver for RK808

2014-08-28 Thread Lee Jones
On Wed, 27 Aug 2014, Dmitry Torokhov wrote: > On Wednesday, August 27, 2014 02:39:36 PM Lee Jones wrote: > > On Tue, 26 Aug 2014, Chris Zhong wrote: > > > + > > > +static struct of_device_id rk808_of_match[] = { > > > + { .compatible = "rockchip,rk808" }, > > > +}; > > > +MODULE_DEVICE_TABLE(of,

Re: [PATCH v6 2/5] MFD: RK808: Add new mfd driver for RK808

2014-08-28 Thread Lee Jones
On Wed, 27 Aug 2014, Dmitry Torokhov wrote: On Wednesday, August 27, 2014 02:39:36 PM Lee Jones wrote: On Tue, 26 Aug 2014, Chris Zhong wrote: + +static struct of_device_id rk808_of_match[] = { + { .compatible = rockchip,rk808 }, +}; +MODULE_DEVICE_TABLE(of, rk808_of_match);

Re: [PATCH v6 2/5] MFD: RK808: Add new mfd driver for RK808

2014-08-27 Thread Heiko Stübner
Hi Chris, Am Dienstag, 26. August 2014, 22:14:04 schrieb Chris Zhong: > The RK808 chip is a power management IC for multimedia and handheld > devices. It contains the following components: > > - Regulators > - RTC > - Clkout > > The RK808 core driver is registered as a platform driver and

Re: [PATCH v6 2/5] MFD: RK808: Add new mfd driver for RK808

2014-08-27 Thread Heiko Stübner
Am Mittwoch, 27. August 2014, 12:59:35 schrieb Doug Anderson: > Heiko, > > On Wed, Aug 27, 2014 at 12:53 PM, Heiko Stübner wrote: > > Hi Chris, > > > > Am Dienstag, 26. August 2014, 22:14:04 schrieb Chris Zhong: > >> The RK808 chip is a power management IC for multimedia and handheld > >>

Re: [PATCH v6 2/5] MFD: RK808: Add new mfd driver for RK808

2014-08-27 Thread Doug Anderson
Dmitry, On Wed, Aug 27, 2014 at 10:21 AM, Dmitry Torokhov wrote: > On Wednesday, August 27, 2014 02:39:36 PM Lee Jones wrote: >> On Tue, 26 Aug 2014, Chris Zhong wrote: >> > + >> > +static struct of_device_id rk808_of_match[] = { >> > + { .compatible = "rockchip,rk808" }, >> > +}; >> >

Re: [PATCH v6 2/5] MFD: RK808: Add new mfd driver for RK808

2014-08-27 Thread Doug Anderson
Heiko, On Wed, Aug 27, 2014 at 12:53 PM, Heiko Stübner wrote: > Hi Chris, > > Am Dienstag, 26. August 2014, 22:14:04 schrieb Chris Zhong: >> The RK808 chip is a power management IC for multimedia and handheld >> devices. It contains the following components: >> >> - Regulators >> - RTC >> -

Re: [PATCH v6 2/5] MFD: RK808: Add new mfd driver for RK808

2014-08-27 Thread Dmitry Torokhov
On Wednesday, August 27, 2014 02:39:36 PM Lee Jones wrote: > On Tue, 26 Aug 2014, Chris Zhong wrote: > > + > > +static struct of_device_id rk808_of_match[] = { > > + { .compatible = "rockchip,rk808" }, > > +}; > > +MODULE_DEVICE_TABLE(of, rk808_of_match); > > + > > +static const struct

Re: [PATCH v6 2/5] MFD: RK808: Add new mfd driver for RK808

2014-08-27 Thread Lee Jones
On Wed, 27 Aug 2014, Doug Anderson wrote: > On Wed, Aug 27, 2014 at 6:39 AM, Lee Jones wrote: > >> +static int rk808_probe(struct i2c_client *client, > >> +const struct i2c_device_id *id) > >> +{ > >> + int ret; > >> + int pm_off = 0; > >> + struct rk808 *rk808; >

Re: [PATCH v6 2/5] MFD: RK808: Add new mfd driver for RK808

2014-08-27 Thread Doug Anderson
Lee, On Wed, Aug 27, 2014 at 6:39 AM, Lee Jones wrote: >> +static int rk808_probe(struct i2c_client *client, >> +const struct i2c_device_id *id) >> +{ >> + int ret; >> + int pm_off = 0; >> + struct rk808 *rk808; >> + struct device_node *np =

Re: [PATCH v6 2/5] MFD: RK808: Add new mfd driver for RK808

2014-08-27 Thread Lee Jones
On Tue, 26 Aug 2014, Chris Zhong wrote: > The RK808 chip is a power management IC for multimedia and handheld > devices. It contains the following components: > > - Regulators > - RTC > - Clkout > > The RK808 core driver is registered as a platform driver and provides > communication through

Re: [PATCH v6 2/5] MFD: RK808: Add new mfd driver for RK808

2014-08-27 Thread Lee Jones
On Tue, 26 Aug 2014, Chris Zhong wrote: The RK808 chip is a power management IC for multimedia and handheld devices. It contains the following components: - Regulators - RTC - Clkout The RK808 core driver is registered as a platform driver and provides communication through I2C with

Re: [PATCH v6 2/5] MFD: RK808: Add new mfd driver for RK808

2014-08-27 Thread Doug Anderson
Lee, On Wed, Aug 27, 2014 at 6:39 AM, Lee Jones lee.jo...@linaro.org wrote: +static int rk808_probe(struct i2c_client *client, +const struct i2c_device_id *id) +{ + int ret; + int pm_off = 0; + struct rk808 *rk808; + struct device_node *np =

Re: [PATCH v6 2/5] MFD: RK808: Add new mfd driver for RK808

2014-08-27 Thread Lee Jones
On Wed, 27 Aug 2014, Doug Anderson wrote: On Wed, Aug 27, 2014 at 6:39 AM, Lee Jones lee.jo...@linaro.org wrote: +static int rk808_probe(struct i2c_client *client, +const struct i2c_device_id *id) +{ + int ret; + int pm_off = 0; + struct rk808 *rk808;

Re: [PATCH v6 2/5] MFD: RK808: Add new mfd driver for RK808

2014-08-27 Thread Dmitry Torokhov
On Wednesday, August 27, 2014 02:39:36 PM Lee Jones wrote: On Tue, 26 Aug 2014, Chris Zhong wrote: + +static struct of_device_id rk808_of_match[] = { + { .compatible = rockchip,rk808 }, +}; +MODULE_DEVICE_TABLE(of, rk808_of_match); + +static const struct i2c_device_id rk808_ids[]

Re: [PATCH v6 2/5] MFD: RK808: Add new mfd driver for RK808

2014-08-27 Thread Doug Anderson
Heiko, On Wed, Aug 27, 2014 at 12:53 PM, Heiko Stübner he...@sntech.de wrote: Hi Chris, Am Dienstag, 26. August 2014, 22:14:04 schrieb Chris Zhong: The RK808 chip is a power management IC for multimedia and handheld devices. It contains the following components: - Regulators - RTC -

Re: [PATCH v6 2/5] MFD: RK808: Add new mfd driver for RK808

2014-08-27 Thread Doug Anderson
Dmitry, On Wed, Aug 27, 2014 at 10:21 AM, Dmitry Torokhov d...@chromium.org wrote: On Wednesday, August 27, 2014 02:39:36 PM Lee Jones wrote: On Tue, 26 Aug 2014, Chris Zhong wrote: + +static struct of_device_id rk808_of_match[] = { + { .compatible = rockchip,rk808 }, +};

Re: [PATCH v6 2/5] MFD: RK808: Add new mfd driver for RK808

2014-08-27 Thread Heiko Stübner
Am Mittwoch, 27. August 2014, 12:59:35 schrieb Doug Anderson: Heiko, On Wed, Aug 27, 2014 at 12:53 PM, Heiko Stübner he...@sntech.de wrote: Hi Chris, Am Dienstag, 26. August 2014, 22:14:04 schrieb Chris Zhong: The RK808 chip is a power management IC for multimedia and handheld

Re: [PATCH v6 2/5] MFD: RK808: Add new mfd driver for RK808

2014-08-27 Thread Heiko Stübner
Hi Chris, Am Dienstag, 26. August 2014, 22:14:04 schrieb Chris Zhong: The RK808 chip is a power management IC for multimedia and handheld devices. It contains the following components: - Regulators - RTC - Clkout The RK808 core driver is registered as a platform driver and provides

Re: [PATCH v6 2/5] MFD: RK808: Add new mfd driver for RK808

2014-08-26 Thread Doug Anderson
Chris, On Tue, Aug 26, 2014 at 7:14 AM, Chris Zhong wrote: > +static struct regmap_irq_chip rk808_irq_chip = { > + .name = "rk808", > + .irqs = rk808_irqs, > + .num_irqs = ARRAY_SIZE(rk808_irqs), > + .num_regs = 2, > + .irq_reg_stride = 2, > + .status_base =

[PATCH v6 2/5] MFD: RK808: Add new mfd driver for RK808

2014-08-26 Thread Chris Zhong
The RK808 chip is a power management IC for multimedia and handheld devices. It contains the following components: - Regulators - RTC - Clkout The RK808 core driver is registered as a platform driver and provides communication through I2C with the host device for the different components.

[PATCH v6 2/5] MFD: RK808: Add new mfd driver for RK808

2014-08-26 Thread Chris Zhong
The RK808 chip is a power management IC for multimedia and handheld devices. It contains the following components: - Regulators - RTC - Clkout The RK808 core driver is registered as a platform driver and provides communication through I2C with the host device for the different components.

Re: [PATCH v6 2/5] MFD: RK808: Add new mfd driver for RK808

2014-08-26 Thread Doug Anderson
Chris, On Tue, Aug 26, 2014 at 7:14 AM, Chris Zhong z...@rock-chips.com wrote: +static struct regmap_irq_chip rk808_irq_chip = { + .name = rk808, + .irqs = rk808_irqs, + .num_irqs = ARRAY_SIZE(rk808_irqs), + .num_regs = 2, + .irq_reg_stride = 2, +