Re: [PATCH v6 3/3] mfd: max14577: Add device tree bindings document

2013-12-04 Thread Lee Jones
> > > +MAXIM MAX14577 multi-function device > > > > Why is Maxim capitalised in such a way? > > > > If you're going to use the term Multi-Function Device, please > > capitalise it. > > > > > +MAX14577 is a Multi-function device with Micro-USB Interface Circuit, Li+ > > > > Same here. > > I'll

Re: [PATCH v6 3/3] mfd: max14577: Add device tree bindings document

2013-12-04 Thread Krzysztof Kozlowski
On Wed, 2013-12-04 at 11:20 +, Lee Jones wrote: > > Add document describing device tree bindings for MAX14577 MFD driver. > > > > Signed-off-by: Krzysztof Kozlowski > > Signed-off-by: Kyungmin Park > > --- > > Documentation/devicetree/bindings/mfd/max14577.txt | 48 > >

Re: [PATCH v6 3/3] mfd: max14577: Add device tree bindings document

2013-12-04 Thread Mark Brown
On Wed, Dec 04, 2013 at 11:20:39AM +, Lee Jones wrote: > > + regulators { > > + compatible = "maxim,max14577-regulator"; > > + > > + safeout_reg: safeout@1 { > The name of the node (not the label:safeout_reg) usually depicts the > type of device,

Re: [PATCH v6 3/3] mfd: max14577: Add device tree bindings document

2013-12-04 Thread Lee Jones
> Add document describing device tree bindings for MAX14577 MFD driver. > > Signed-off-by: Krzysztof Kozlowski > Signed-off-by: Kyungmin Park > --- > Documentation/devicetree/bindings/mfd/max14577.txt | 48 > > 1 file changed, 48 insertions(+) > create mode 100644

Re: [PATCH v6 3/3] mfd: max14577: Add device tree bindings document

2013-12-04 Thread Chanwoo Choi
On 12/04/2013 08:03 PM, Krzysztof Kozlowski wrote: > On Wed, 2013-12-04 at 20:01 +0900, Chanwoo Choi wrote: >> On 12/04/2013 07:56 PM, Krzysztof Kozlowski wrote: >>> On Wed, 2013-12-04 at 19:50 +0900, Chanwoo Choi wrote: > (...) I prefer to add dt data about max14577-muic on following:

Re: [PATCH v6 3/3] mfd: max14577: Add device tree bindings document

2013-12-04 Thread Krzysztof Kozlowski
On Wed, 2013-12-04 at 20:01 +0900, Chanwoo Choi wrote: > On 12/04/2013 07:56 PM, Krzysztof Kozlowski wrote: > > On Wed, 2013-12-04 at 19:50 +0900, Chanwoo Choi wrote: (...) > >> > >> I prefer to add dt data about max14577-muic on following: > >> If extcon consumer driver need to use muic device,

Re: [PATCH v6 3/3] mfd: max14577: Add device tree bindings document

2013-12-04 Thread Chanwoo Choi
On 12/04/2013 07:56 PM, Krzysztof Kozlowski wrote: > On Wed, 2013-12-04 at 19:50 +0900, Chanwoo Choi wrote: >> Hi Krzysztof, >> >> On 12/04/2013 07:40 PM, Krzysztof Kozlowski wrote: >>> Add document describing device tree bindings for MAX14577 MFD driver. >>> >>> Signed-off-by: Krzysztof Kozlowski

Re: [PATCH v6 3/3] mfd: max14577: Add device tree bindings document

2013-12-04 Thread Krzysztof Kozlowski
On Wed, 2013-12-04 at 19:50 +0900, Chanwoo Choi wrote: > Hi Krzysztof, > > On 12/04/2013 07:40 PM, Krzysztof Kozlowski wrote: > > Add document describing device tree bindings for MAX14577 MFD driver. > > > > Signed-off-by: Krzysztof Kozlowski > > Signed-off-by: Kyungmin Park > > --- > >

Re: [PATCH v6 3/3] mfd: max14577: Add device tree bindings document

2013-12-04 Thread Chanwoo Choi
Hi Krzysztof, On 12/04/2013 07:40 PM, Krzysztof Kozlowski wrote: > Add document describing device tree bindings for MAX14577 MFD driver. > > Signed-off-by: Krzysztof Kozlowski > Signed-off-by: Kyungmin Park > --- > Documentation/devicetree/bindings/mfd/max14577.txt | 48 >

[PATCH v6 3/3] mfd: max14577: Add device tree bindings document

2013-12-04 Thread Krzysztof Kozlowski
Add document describing device tree bindings for MAX14577 MFD driver. Signed-off-by: Krzysztof Kozlowski Signed-off-by: Kyungmin Park --- Documentation/devicetree/bindings/mfd/max14577.txt | 48 1 file changed, 48 insertions(+) create mode 100644

[PATCH v6 3/3] mfd: max14577: Add device tree bindings document

2013-12-04 Thread Krzysztof Kozlowski
Add document describing device tree bindings for MAX14577 MFD driver. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Documentation/devicetree/bindings/mfd/max14577.txt | 48 1 file changed, 48

Re: [PATCH v6 3/3] mfd: max14577: Add device tree bindings document

2013-12-04 Thread Chanwoo Choi
Hi Krzysztof, On 12/04/2013 07:40 PM, Krzysztof Kozlowski wrote: Add document describing device tree bindings for MAX14577 MFD driver. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

Re: [PATCH v6 3/3] mfd: max14577: Add device tree bindings document

2013-12-04 Thread Krzysztof Kozlowski
On Wed, 2013-12-04 at 19:50 +0900, Chanwoo Choi wrote: Hi Krzysztof, On 12/04/2013 07:40 PM, Krzysztof Kozlowski wrote: Add document describing device tree bindings for MAX14577 MFD driver. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Signed-off-by: Kyungmin Park

Re: [PATCH v6 3/3] mfd: max14577: Add device tree bindings document

2013-12-04 Thread Chanwoo Choi
On 12/04/2013 07:56 PM, Krzysztof Kozlowski wrote: On Wed, 2013-12-04 at 19:50 +0900, Chanwoo Choi wrote: Hi Krzysztof, On 12/04/2013 07:40 PM, Krzysztof Kozlowski wrote: Add document describing device tree bindings for MAX14577 MFD driver. Signed-off-by: Krzysztof Kozlowski

Re: [PATCH v6 3/3] mfd: max14577: Add device tree bindings document

2013-12-04 Thread Krzysztof Kozlowski
On Wed, 2013-12-04 at 20:01 +0900, Chanwoo Choi wrote: On 12/04/2013 07:56 PM, Krzysztof Kozlowski wrote: On Wed, 2013-12-04 at 19:50 +0900, Chanwoo Choi wrote: (...) I prefer to add dt data about max14577-muic on following: If extcon consumer driver need to use muic device, dts should

Re: [PATCH v6 3/3] mfd: max14577: Add device tree bindings document

2013-12-04 Thread Chanwoo Choi
On 12/04/2013 08:03 PM, Krzysztof Kozlowski wrote: On Wed, 2013-12-04 at 20:01 +0900, Chanwoo Choi wrote: On 12/04/2013 07:56 PM, Krzysztof Kozlowski wrote: On Wed, 2013-12-04 at 19:50 +0900, Chanwoo Choi wrote: (...) I prefer to add dt data about max14577-muic on following: If extcon

Re: [PATCH v6 3/3] mfd: max14577: Add device tree bindings document

2013-12-04 Thread Lee Jones
Add document describing device tree bindings for MAX14577 MFD driver. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Documentation/devicetree/bindings/mfd/max14577.txt | 48 1 file changed, 48

Re: [PATCH v6 3/3] mfd: max14577: Add device tree bindings document

2013-12-04 Thread Mark Brown
On Wed, Dec 04, 2013 at 11:20:39AM +, Lee Jones wrote: + regulators { + compatible = maxim,max14577-regulator; + + safeout_reg: safeout@1 { The name of the node (not the label:safeout_reg) usually depicts the type of device, so

Re: [PATCH v6 3/3] mfd: max14577: Add device tree bindings document

2013-12-04 Thread Krzysztof Kozlowski
On Wed, 2013-12-04 at 11:20 +, Lee Jones wrote: Add document describing device tree bindings for MAX14577 MFD driver. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

Re: [PATCH v6 3/3] mfd: max14577: Add device tree bindings document

2013-12-04 Thread Lee Jones
+MAXIM MAX14577 multi-function device Why is Maxim capitalised in such a way? If you're going to use the term Multi-Function Device, please capitalise it. +MAX14577 is a Multi-function device with Micro-USB Interface Circuit, Li+ Same here. I'll fix this. The MAXIM