Re: [PATCH v6 32/57] perf: Remove dev_err() usage after platform_get_irq()

2019-07-31 Thread Stephen Boyd
Quoting Will Deacon (2019-07-31 01:40:57) > On Tue, Jul 30, 2019 at 11:15:32AM -0700, Stephen Boyd wrote: > > Cc: Mark Rutland > > Cc: linux-arm-ker...@lists.infradead.org > > Cc: Greg Kroah-Hartman > > Signed-off-by: Stephen Boyd > > Acked-by: Will Deacon > > Please let me know if you'd

Re: [PATCH v6 32/57] perf: Remove dev_err() usage after platform_get_irq()

2019-07-31 Thread Will Deacon
On Tue, Jul 30, 2019 at 11:15:32AM -0700, Stephen Boyd wrote: > We don't need dev_err() messages when platform_get_irq() fails now that > platform_get_irq() prints an error message itself when something goes > wrong. Let's remove these prints with a simple semantic patch. > > // > @@ >

[PATCH v6 32/57] perf: Remove dev_err() usage after platform_get_irq()

2019-07-30 Thread Stephen Boyd
We don't need dev_err() messages when platform_get_irq() fails now that platform_get_irq() prints an error message itself when something goes wrong. Let's remove these prints with a simple semantic patch. // @@ expression ret; struct platform_device *E; @@ ret = ( platform_get_irq(E, ...) |