Re: [PATCH v6 4/5] devfreq_cooling: add trace information

2015-10-14 Thread Steven Rostedt
On Wed, 14 Oct 2015 12:53:30 +0100 Javi Merino wrote: > > The rest looks fine to me. > > Can I treat that last statement as an Acked-by? Sure, why not ;-) -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org

Re: [PATCH v6 4/5] devfreq_cooling: add trace information

2015-10-14 Thread Javi Merino
Hi Steve, On Thu, Sep 10, 2015 at 06:19:28PM +0100, Steven Rostedt wrote: > On Thu, 10 Sep 2015 18:09:31 +0100 > Javi Merino wrote: > > > Tracing is useful for debugging and performance tuning. Add similar > > traces to what's present in the cpu cooling device. > > > > Cc: Zhang Rui > > Cc:

Re: [PATCH v6 4/5] devfreq_cooling: add trace information

2015-10-14 Thread Javi Merino
Hi Steve, On Thu, Sep 10, 2015 at 06:19:28PM +0100, Steven Rostedt wrote: > On Thu, 10 Sep 2015 18:09:31 +0100 > Javi Merino wrote: > > > Tracing is useful for debugging and performance tuning. Add similar > > traces to what's present in the cpu cooling device. > > > >

Re: [PATCH v6 4/5] devfreq_cooling: add trace information

2015-10-14 Thread Steven Rostedt
On Wed, 14 Oct 2015 12:53:30 +0100 Javi Merino wrote: > > The rest looks fine to me. > > Can I treat that last statement as an Acked-by? Sure, why not ;-) -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH v6 4/5] devfreq_cooling: add trace information

2015-09-18 Thread Steven Rostedt
On Fri, 18 Sep 2015 14:55:51 +0100 Javi Merino wrote: > > A tracepoint does some whacky things, and gcc may not optimize this. > > I've compared the generated assembly on arm, arm64 and x86_64 and both > options generate exactly the same code. Thanks for checking. I was just curious, and I'm

Re: [PATCH v6 4/5] devfreq_cooling: add trace information

2015-09-18 Thread Javi Merino
Hi Steve, On Thu, Sep 10, 2015 at 06:19:28PM +0100, Steven Rostedt wrote: > On Thu, 10 Sep 2015 18:09:31 +0100 > Javi Merino wrote: > > > Tracing is useful for debugging and performance tuning. Add similar > > traces to what's present in the cpu cooling device. > > > > Cc: Zhang Rui > > Cc:

Re: [PATCH v6 4/5] devfreq_cooling: add trace information

2015-09-18 Thread Javi Merino
Hi Steve, On Thu, Sep 10, 2015 at 06:19:28PM +0100, Steven Rostedt wrote: > On Thu, 10 Sep 2015 18:09:31 +0100 > Javi Merino wrote: > > > Tracing is useful for debugging and performance tuning. Add similar > > traces to what's present in the cpu cooling device. > > > >

Re: [PATCH v6 4/5] devfreq_cooling: add trace information

2015-09-18 Thread Steven Rostedt
On Fri, 18 Sep 2015 14:55:51 +0100 Javi Merino wrote: > > A tracepoint does some whacky things, and gcc may not optimize this. > > I've compared the generated assembly on arm, arm64 and x86_64 and both > options generate exactly the same code. Thanks for checking. I was

Re: [PATCH v6 4/5] devfreq_cooling: add trace information

2015-09-10 Thread Steven Rostedt
On Thu, 10 Sep 2015 18:09:31 +0100 Javi Merino wrote: > Tracing is useful for debugging and performance tuning. Add similar > traces to what's present in the cpu cooling device. > > Cc: Zhang Rui > Cc: Eduardo Valentin > Cc: Steven Rostedt > Cc: Ingo Molnar > Signed-off-by: Javi Merino >

[PATCH v6 4/5] devfreq_cooling: add trace information

2015-09-10 Thread Javi Merino
Tracing is useful for debugging and performance tuning. Add similar traces to what's present in the cpu cooling device. Cc: Zhang Rui Cc: Eduardo Valentin Cc: Steven Rostedt Cc: Ingo Molnar Signed-off-by: Javi Merino --- drivers/thermal/devfreq_cooling.c | 6 +

Re: [PATCH v6 4/5] devfreq_cooling: add trace information

2015-09-10 Thread Steven Rostedt
On Thu, 10 Sep 2015 18:09:31 +0100 Javi Merino wrote: > Tracing is useful for debugging and performance tuning. Add similar > traces to what's present in the cpu cooling device. > > Cc: Zhang Rui > Cc: Eduardo Valentin > Cc:

[PATCH v6 4/5] devfreq_cooling: add trace information

2015-09-10 Thread Javi Merino
Tracing is useful for debugging and performance tuning. Add similar traces to what's present in the cpu cooling device. Cc: Zhang Rui Cc: Eduardo Valentin Cc: Steven Rostedt Cc: Ingo Molnar Signed-off-by: Javi