Re: [PATCH v6 5/6] i2c: at91: print hardware version

2015-06-10 Thread Wolfram Sang
> >>>- dev_info(dev->dev, "AT91 i2c bus driver.\n"); > >>>+ dev_info(dev->dev, "AT91 i2c bus driver (version: %#x).\n", > > >>It looks as if you rather print the driver's version. :-) > > > From my point of view, having a version number for a Linux driver would > >be strange > >Not

Re: [PATCH v6 5/6] i2c: at91: print hardware version

2015-06-10 Thread Sergei Shtylyov
Hello. On 6/10/2015 11:05 AM, Ludovic Desroches wrote: The probe() function now prints the hardware version of the I2C controller. Signed-off-by: Cyrille Pitchen --- drivers/i2c/busses/i2c-at91.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v6 5/6] i2c: at91: print hardware version

2015-06-10 Thread Ludovic Desroches
On Tue, Jun 09, 2015 at 10:46:20PM +0300, Sergei Shtylyov wrote: > Hello. > > On 06/09/2015 07:22 PM, Cyrille Pitchen wrote: > > >The probe() function now prints the hardware version of the I2C > >controller. > > >Signed-off-by: Cyrille Pitchen > >--- > > drivers/i2c/busses/i2c-at91.c | 5

Re: [PATCH v6 5/6] i2c: at91: print hardware version

2015-06-10 Thread Ludovic Desroches
On Tue, Jun 09, 2015 at 10:46:20PM +0300, Sergei Shtylyov wrote: Hello. On 06/09/2015 07:22 PM, Cyrille Pitchen wrote: The probe() function now prints the hardware version of the I2C controller. Signed-off-by: Cyrille Pitchen cyrille.pitc...@atmel.com ---

Re: [PATCH v6 5/6] i2c: at91: print hardware version

2015-06-10 Thread Wolfram Sang
- dev_info(dev-dev, AT91 i2c bus driver.\n); + dev_info(dev-dev, AT91 i2c bus driver (version: %#x).\n, It looks as if you rather print the driver's version. :-) From my point of view, having a version number for a Linux driver would be strange Not everybody shares your

Re: [PATCH v6 5/6] i2c: at91: print hardware version

2015-06-10 Thread Sergei Shtylyov
Hello. On 6/10/2015 11:05 AM, Ludovic Desroches wrote: The probe() function now prints the hardware version of the I2C controller. Signed-off-by: Cyrille Pitchen cyrille.pitc...@atmel.com --- drivers/i2c/busses/i2c-at91.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

Re: [PATCH v6 5/6] i2c: at91: print hardware version

2015-06-09 Thread Sergei Shtylyov
Hello. On 06/09/2015 07:22 PM, Cyrille Pitchen wrote: The probe() function now prints the hardware version of the I2C controller. Signed-off-by: Cyrille Pitchen --- drivers/i2c/busses/i2c-at91.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH v6 5/6] i2c: at91: print hardware version

2015-06-09 Thread Cyrille Pitchen
The probe() function now prints the hardware version of the I2C controller. Signed-off-by: Cyrille Pitchen --- drivers/i2c/busses/i2c-at91.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c index

[PATCH v6 5/6] i2c: at91: print hardware version

2015-06-09 Thread Cyrille Pitchen
The probe() function now prints the hardware version of the I2C controller. Signed-off-by: Cyrille Pitchen cyrille.pitc...@atmel.com --- drivers/i2c/busses/i2c-at91.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-at91.c

Re: [PATCH v6 5/6] i2c: at91: print hardware version

2015-06-09 Thread Sergei Shtylyov
Hello. On 06/09/2015 07:22 PM, Cyrille Pitchen wrote: The probe() function now prints the hardware version of the I2C controller. Signed-off-by: Cyrille Pitchen cyrille.pitc...@atmel.com --- drivers/i2c/busses/i2c-at91.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff