Re: [PATCH v6 6/6] powerpc/perf: split callchain.c by bitness

2019-09-01 Thread Michael Ellerman
Michal Suchánek writes: > On Fri, 30 Aug 2019 20:57:57 +0200 > Michal Suchanek wrote: > >> Building callchain.c with !COMPAT proved quite ugly with all the >> defines. Splitting out the 32bit and 64bit parts looks better. >> > > BTW the powerpc callchain.c does not match any of the patterns of

Re: [PATCH v6 6/6] powerpc/perf: split callchain.c by bitness

2019-08-30 Thread Christophe Leroy
Le 30/08/2019 à 20:57, Michal Suchanek a écrit : Building callchain.c with !COMPAT proved quite ugly with all the defines. Splitting out the 32bit and 64bit parts looks better. No code change intended. Signed-off-by: Michal Suchanek Reviewed-by: Christophe Leroy --- v6: - move

Re: [PATCH v6 6/6] powerpc/perf: split callchain.c by bitness

2019-08-30 Thread Michal Suchánek
On Fri, 30 Aug 2019 20:57:57 +0200 Michal Suchanek wrote: > Building callchain.c with !COMPAT proved quite ugly with all the > defines. Splitting out the 32bit and 64bit parts looks better. > BTW the powerpc callchain.c does not match any of the patterns of PERF CORE in MAINTAINERS (unlike

[PATCH v6 6/6] powerpc/perf: split callchain.c by bitness

2019-08-30 Thread Michal Suchanek
Building callchain.c with !COMPAT proved quite ugly with all the defines. Splitting out the 32bit and 64bit parts looks better. No code change intended. Signed-off-by: Michal Suchanek --- v6: - move current_is_64bit consolidetaion to earlier patch - move defines to the top of callchain_32.c