Re: [PATCH v6 7/7] tpm: pass an array of tpm_bank_list structures to tpm_pcr_extend()

2018-12-13 Thread Jarkko Sakkinen
On Thu, Dec 13, 2018 at 08:57:17AM +0100, Roberto Sassu wrote: > > 1. The function does not fail if alg_id is not found. This will go > > silent. > > It is intentional. If alg_id is not found, the PCR is extended with the > first digest passed by the caller of tpm_pcr_extend(). If no digest wa

Re: [PATCH v6 7/7] tpm: pass an array of tpm_bank_list structures to tpm_pcr_extend()

2018-12-12 Thread Roberto Sassu
On 12/12/2018 7:27 PM, Jarkko Sakkinen wrote: On Thu, Dec 06, 2018 at 07:38:30PM +0100, Roberto Sassu wrote: On 12/5/2018 1:14 AM, Jarkko Sakkinen wrote: On Tue, Dec 04, 2018 at 09:21:38AM +0100, Roberto Sassu wrote: The new tpm_bank_list structure has been preferred to the tpm_digest structur

Re: [PATCH v6 7/7] tpm: pass an array of tpm_bank_list structures to tpm_pcr_extend()

2018-12-12 Thread Jarkko Sakkinen
On Thu, Dec 06, 2018 at 07:38:30PM +0100, Roberto Sassu wrote: > On 12/5/2018 1:14 AM, Jarkko Sakkinen wrote: > > On Tue, Dec 04, 2018 at 09:21:38AM +0100, Roberto Sassu wrote: > > > The new tpm_bank_list structure has been preferred to the tpm_digest > > > structure, to let the caller specify the

Re: [PATCH v6 7/7] tpm: pass an array of tpm_bank_list structures to tpm_pcr_extend()

2018-12-12 Thread Jarkko Sakkinen
On Thu, Dec 06, 2018 at 07:09:48PM +0100, Roberto Sassu wrote: > > > On 12/5/2018 1:14 AM, Jarkko Sakkinen wrote: > > On Tue, Dec 04, 2018 at 09:21:38AM +0100, Roberto Sassu wrote: > > > The new tpm_bank_list structure has been preferred to the tpm_digest > > > structure, to let the caller specif

Re: [PATCH v6 7/7] tpm: pass an array of tpm_bank_list structures to tpm_pcr_extend()

2018-12-06 Thread Roberto Sassu
On 12/5/2018 1:14 AM, Jarkko Sakkinen wrote: On Tue, Dec 04, 2018 at 09:21:38AM +0100, Roberto Sassu wrote: The new tpm_bank_list structure has been preferred to the tpm_digest structure, to let the caller specify the size of the digest (which may be unknown to the TPM driver). Why is that? Di

Re: [PATCH v6 7/7] tpm: pass an array of tpm_bank_list structures to tpm_pcr_extend()

2018-12-06 Thread Roberto Sassu
On 12/5/2018 1:14 AM, Jarkko Sakkinen wrote: On Tue, Dec 04, 2018 at 09:21:38AM +0100, Roberto Sassu wrote: The new tpm_bank_list structure has been preferred to the tpm_digest structure, to let the caller specify the size of the digest (which may be unknown to the TPM driver). Why is that?

Re: [PATCH v6 7/7] tpm: pass an array of tpm_bank_list structures to tpm_pcr_extend()

2018-12-04 Thread Jarkko Sakkinen
On Tue, Dec 04, 2018 at 09:21:38AM +0100, Roberto Sassu wrote: > The new tpm_bank_list structure has been preferred to the tpm_digest > structure, to let the caller specify the size of the digest (which may be > unknown to the TPM driver). Why is that? Didn't previous commit query these? > +struc

[PATCH v6 7/7] tpm: pass an array of tpm_bank_list structures to tpm_pcr_extend()

2018-12-04 Thread Roberto Sassu
Currently, tpm_pcr_extend() accepts as an input only a SHA1 digest. This patch modifies the definition of tpm_pcr_extend() to allow other kernel subsystems to pass a digest for each algorithm supported by the TPM. All digests are processed by the TPM in one operation. If a tpm_pcr_extend() caller