Re: [PATCH v6 7/8] dynamic_debug: add asm-generic implementation for DYNAMIC_DEBUG_RELATIVE_POINTERS

2019-06-27 Thread Nick Desaulniers
On Wed, Jun 26, 2019 at 4:52 PM Rasmus Villemoes wrote: > > On 27/06/2019 01.16, Nick Desaulniers wrote: > > On Tue, Jun 25, 2019 at 3:18 PM Nick Desaulniers > > wrote: > > > > The prints should show up in dmesg right, assuming you do something to > > trigger them? Can you provide more details

Re: [PATCH v6 7/8] dynamic_debug: add asm-generic implementation for DYNAMIC_DEBUG_RELATIVE_POINTERS

2019-06-26 Thread Rasmus Villemoes
On 27/06/2019 01.16, Nick Desaulniers wrote: > On Tue, Jun 25, 2019 at 3:18 PM Nick Desaulniers > wrote: > > The prints should show up in dmesg right, assuming you do something to > trigger them? Can you provide more details for a test case that's > easy to trip? What's an easy case to

Re: [PATCH v6 7/8] dynamic_debug: add asm-generic implementation for DYNAMIC_DEBUG_RELATIVE_POINTERS

2019-06-26 Thread Nick Desaulniers
On Tue, Jun 25, 2019 at 3:18 PM Nick Desaulniers wrote: > 2. pci_pm_suspend_noirq seems to exist twice(?) before your patches, once > after > 3. xhci_urb_enqueue seems to exist three times before your patches, twice > after PEBKAC, I advanced my master branch without rebasing my local branch

Re: [PATCH v6 7/8] dynamic_debug: add asm-generic implementation for DYNAMIC_DEBUG_RELATIVE_POINTERS

2019-06-25 Thread Nick Desaulniers
On Mon, Jun 24, 2019 at 11:35 PM Rasmus Villemoes wrote: > > On 24/06/2019 23.53, Nick Desaulniers wrote: > > On Thu, Jun 20, 2019 at 1:46 PM Rasmus Villemoes > > wrote: > >> Well, apart from booting, I've mostly just tested that the debugfs > >> control file is identical before and after

Re: [PATCH v6 7/8] dynamic_debug: add asm-generic implementation for DYNAMIC_DEBUG_RELATIVE_POINTERS

2019-06-25 Thread Rasmus Villemoes
On 24/06/2019 23.53, Nick Desaulniers wrote: > On Thu, Jun 20, 2019 at 1:46 PM Rasmus Villemoes > wrote: >> >> I've pushed them to https://github.com/Villemoes/linux/tree/dyndebug_v6 >> . They rebase pretty cleanly to just about anything you might prefer >> testing on. Enabling it for arm64 or

Re: [PATCH v6 7/8] dynamic_debug: add asm-generic implementation for DYNAMIC_DEBUG_RELATIVE_POINTERS

2019-06-24 Thread Nick Desaulniers
On Thu, Jun 20, 2019 at 1:46 PM Rasmus Villemoes wrote: > > On 18/06/2019 00.35, Nick Desaulniers wrote: > > On Mon, Jun 17, 2019 at 3:20 PM Rasmus Villemoes > > wrote: > >> > >> It relies on > >> > >> (1) standard assembly directives that should work on > >> all architectures > >> (2) the "i"

Re: [PATCH v6 7/8] dynamic_debug: add asm-generic implementation for DYNAMIC_DEBUG_RELATIVE_POINTERS

2019-06-20 Thread Rasmus Villemoes
On 18/06/2019 00.35, Nick Desaulniers wrote: > On Mon, Jun 17, 2019 at 3:20 PM Rasmus Villemoes > wrote: >> >> It relies on >> >> (1) standard assembly directives that should work on >> all architectures >> (2) the "i" constraint for an constant, and >> (3) %cN emitting the constant operand N

Re: [PATCH v6 7/8] dynamic_debug: add asm-generic implementation for DYNAMIC_DEBUG_RELATIVE_POINTERS

2019-06-17 Thread Nick Desaulniers
On Mon, Jun 17, 2019 at 3:20 PM Rasmus Villemoes wrote: > > A 64 bit architecture can allow reducing the size of the kernel image by > selecting HAVE_DYNAMIC_DEBUG_RELATIVE_POINTERS, but it must provide > a proper DEFINE_DYNAMIC_DEBUG_METADATA macro for emitting the struct > _ddebug in assembly.

[PATCH v6 7/8] dynamic_debug: add asm-generic implementation for DYNAMIC_DEBUG_RELATIVE_POINTERS

2019-06-17 Thread Rasmus Villemoes
A 64 bit architecture can allow reducing the size of the kernel image by selecting HAVE_DYNAMIC_DEBUG_RELATIVE_POINTERS, but it must provide a proper DEFINE_DYNAMIC_DEBUG_METADATA macro for emitting the struct _ddebug in assembly. However, since that does not involve any instructions, this generic