Re: [PATCH v6 7/8] x86: patch all traced function calls using the int3-based framework

2014-01-23 Thread Steven Rostedt
On Thu, 23 Jan 2014 15:21:42 +0100 Petr Mladek wrote: > It means that the slowness caused by tracing "text_poke*" stuff is > comparable with the slowness caused by "run_sync()". It might mean that > "text_poke_bp_list" is not worth the added complexity. I'm starting to think it's fine keeping

Re: [PATCH v6 7/8] x86: patch all traced function calls using the int3-based framework

2014-01-23 Thread Petr Mladek
On Wed, 2014-01-22 at 14:20 +0100, Petr Mladek wrote: > On Wed, 2014-01-15 at 10:47 -0500, Steven Rostedt wrote: > > On Tue, 10 Dec 2013 16:42:19 +0100 > > Petr Mladek wrote: > > > > > > > > diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c > > > index

Re: [PATCH v6 7/8] x86: patch all traced function calls using the int3-based framework

2014-01-23 Thread Petr Mladek
On Wed, 2014-01-22 at 14:20 +0100, Petr Mladek wrote: On Wed, 2014-01-15 at 10:47 -0500, Steven Rostedt wrote: On Tue, 10 Dec 2013 16:42:19 +0100 Petr Mladek pmla...@suse.cz wrote: diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c index

Re: [PATCH v6 7/8] x86: patch all traced function calls using the int3-based framework

2014-01-23 Thread Steven Rostedt
On Thu, 23 Jan 2014 15:21:42 +0100 Petr Mladek pmla...@suse.cz wrote: It means that the slowness caused by tracing text_poke* stuff is comparable with the slowness caused by run_sync(). It might mean that text_poke_bp_list is not worth the added complexity. I'm starting to think it's fine

Re: [PATCH v6 7/8] x86: patch all traced function calls using the int3-based framework

2014-01-22 Thread Petr Mladek
On Wed, 2014-01-15 at 10:47 -0500, Steven Rostedt wrote: > On Tue, 10 Dec 2013 16:42:19 +0100 > Petr Mladek wrote: > > > > > diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c > > index 03abf9abf681..e5c02af3a8cc 100644 > > --- a/arch/x86/kernel/alternative.c > > +++

Re: [PATCH v6 7/8] x86: patch all traced function calls using the int3-based framework

2014-01-22 Thread Petr Mladek
On Wed, 2014-01-15 at 10:47 -0500, Steven Rostedt wrote: On Tue, 10 Dec 2013 16:42:19 +0100 Petr Mladek pmla...@suse.cz wrote: diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c index 03abf9abf681..e5c02af3a8cc 100644 --- a/arch/x86/kernel/alternative.c +++

Re: [PATCH v6 7/8] x86: patch all traced function calls using the int3-based framework

2014-01-15 Thread Steven Rostedt
On Tue, 10 Dec 2013 16:42:19 +0100 Petr Mladek wrote: > > diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c > index 03abf9abf681..e5c02af3a8cc 100644 > --- a/arch/x86/kernel/alternative.c > +++ b/arch/x86/kernel/alternative.c > @@ -613,7 +613,7 @@ void __kprobes

Re: [PATCH v6 7/8] x86: patch all traced function calls using the int3-based framework

2014-01-15 Thread Steven Rostedt
On Tue, 10 Dec 2013 16:42:19 +0100 Petr Mladek pmla...@suse.cz wrote: diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c index 03abf9abf681..e5c02af3a8cc 100644 --- a/arch/x86/kernel/alternative.c +++ b/arch/x86/kernel/alternative.c @@ -613,7 +613,7 @@ void

[PATCH v6 7/8] x86: patch all traced function calls using the int3-based framework

2013-12-10 Thread Petr Mladek
Let's continue with replacing the existing Int3-based framework in ftrace with the new generic function introduced by the commit fd4363fff3d9 (x86: Introduce int3 (breakpoint)-based instruction patching) This time use it in ftrace_replace_code that modifies all the watched function calls. If we

[PATCH v6 7/8] x86: patch all traced function calls using the int3-based framework

2013-12-10 Thread Petr Mladek
Let's continue with replacing the existing Int3-based framework in ftrace with the new generic function introduced by the commit fd4363fff3d9 (x86: Introduce int3 (breakpoint)-based instruction patching) This time use it in ftrace_replace_code that modifies all the watched function calls. If we