Re: [RESEND PATCH v7] acpi: apei: remove the unused dead-code for SEA/NMI notification type

On Sun, Oct 22, 2017 at 06:06:10PM +0800, gengdongjiu wrote: > Thanks a lot Rafael's applying. > Both for me is OK. You should never agree if a patch has the SOB chain wrong. It might sound trivial and not important for your current purposes but proving the origin of a patch and how it found its

Re: [RESEND PATCH v7] acpi: apei: remove the unused dead-code for SEA/NMI notification type

On Sun, Oct 22, 2017 at 06:06:10PM +0800, gengdongjiu wrote: > Thanks a lot Rafael's applying. > Both for me is OK. You should never agree if a patch has the SOB chain wrong. It might sound trivial and not important for your current purposes but proving the origin of a patch and how it found its

Re: [RESEND PATCH v7] acpi: apei: remove the unused dead-code for SEA/NMI notification type

On 2017/10/22 17:38, Rafael J. Wysocki wrote: > On Sun, Oct 22, 2017 at 8:54 AM, Dongjiu Geng wrote: >> For the SEA notification, the two functions ghes_sea_add() and >> ghes_sea_remove() are only called when CONFIG_ACPI_APEI_SEA >> is defined. If not, it will return

Re: [RESEND PATCH v7] acpi: apei: remove the unused dead-code for SEA/NMI notification type

On 2017/10/22 17:38, Rafael J. Wysocki wrote: > On Sun, Oct 22, 2017 at 8:54 AM, Dongjiu Geng wrote: >> For the SEA notification, the two functions ghes_sea_add() and >> ghes_sea_remove() are only called when CONFIG_ACPI_APEI_SEA >> is defined. If not, it will return errors in the ghes_probe()

Re: [RESEND PATCH v7] acpi: apei: remove the unused dead-code for SEA/NMI notification type

On 2017/10/22 17:38, Rafael J. Wysocki wrote: >> Tested-by: Tyler Baicar >> Reviewed-by: Borislav Petkov > I applied one of the previous iterations. > > Do I need to replace it with this version? > Thanks a lot Rafael's applying. Both for me is OK. If

Re: [RESEND PATCH v7] acpi: apei: remove the unused dead-code for SEA/NMI notification type

On 2017/10/22 17:38, Rafael J. Wysocki wrote: >> Tested-by: Tyler Baicar >> Reviewed-by: Borislav Petkov > I applied one of the previous iterations. > > Do I need to replace it with this version? > Thanks a lot Rafael's applying. Both for me is OK. If Borislav agreed, may be not. I will pay

Re: [RESEND PATCH v7] acpi: apei: remove the unused dead-code for SEA/NMI notification type

On Sun, Oct 22, 2017 at 8:54 AM, Dongjiu Geng wrote: > For the SEA notification, the two functions ghes_sea_add() and > ghes_sea_remove() are only called when CONFIG_ACPI_APEI_SEA > is defined. If not, it will return errors in the ghes_probe() > and not continue. If the

Re: [RESEND PATCH v7] acpi: apei: remove the unused dead-code for SEA/NMI notification type

On Sun, Oct 22, 2017 at 8:54 AM, Dongjiu Geng wrote: > For the SEA notification, the two functions ghes_sea_add() and > ghes_sea_remove() are only called when CONFIG_ACPI_APEI_SEA > is defined. If not, it will return errors in the ghes_probe() > and not continue. If the probe is failed, the

Re: [PATCH v7] acpi: apei: remove the unused dead-code for SEA/NMI notification type

On 2017/10/21 20:15, Borislav Petkov wrote: >> Signed-off-by: Dongjiu Geng >> Tested-by: Tyler Baicar >> Signed-off-by: Borislav Petkov > I gave you Reviewed-by, not Signed-off-by. > > Before you send more patches, read this: > >

Re: [PATCH v7] acpi: apei: remove the unused dead-code for SEA/NMI notification type

On 2017/10/21 20:15, Borislav Petkov wrote: >> Signed-off-by: Dongjiu Geng >> Tested-by: Tyler Baicar >> Signed-off-by: Borislav Petkov > I gave you Reviewed-by, not Signed-off-by. > > Before you send more patches, read this: > > Documentation/process/submitting-patches.rst > > You can

[RESEND PATCH v7] acpi: apei: remove the unused dead-code for SEA/NMI notification type

For the SEA notification, the two functions ghes_sea_add() and ghes_sea_remove() are only called when CONFIG_ACPI_APEI_SEA is defined. If not, it will return errors in the ghes_probe() and not continue. If the probe is failed, the ghes_sea_remove() also has no chance to be called. Hence, remove

[RESEND PATCH v7] acpi: apei: remove the unused dead-code for SEA/NMI notification type

For the SEA notification, the two functions ghes_sea_add() and ghes_sea_remove() are only called when CONFIG_ACPI_APEI_SEA is defined. If not, it will return errors in the ghes_probe() and not continue. If the probe is failed, the ghes_sea_remove() also has no chance to be called. Hence, remove

Re: [PATCH v7] acpi: apei: remove the unused dead-code for SEA/NMI notification type

On Sat, Oct 21, 2017 at 06:35:03PM +0800, Dongjiu Geng wrote: > For the SEA notification, the two functions ghes_sea_add() and > ghes_sea_remove() are only called when CONFIG_ACPI_APEI_SEA > is defined. If not, it will return errors in the ghes_probe() > and not continue. If the probe is failed,

Re: [PATCH v7] acpi: apei: remove the unused dead-code for SEA/NMI notification type

On Sat, Oct 21, 2017 at 06:35:03PM +0800, Dongjiu Geng wrote: > For the SEA notification, the two functions ghes_sea_add() and > ghes_sea_remove() are only called when CONFIG_ACPI_APEI_SEA > is defined. If not, it will return errors in the ghes_probe() > and not continue. If the probe is failed,

[PATCH v7] acpi: apei: remove the unused dead-code for SEA/NMI notification type

For the SEA notification, the two functions ghes_sea_add() and ghes_sea_remove() are only called when CONFIG_ACPI_APEI_SEA is defined. If not, it will return errors in the ghes_probe() and not continue. If the probe is failed, the ghes_sea_remove() also has no chance to be called. Hence, remove

[PATCH v7] acpi: apei: remove the unused dead-code for SEA/NMI notification type

For the SEA notification, the two functions ghes_sea_add() and ghes_sea_remove() are only called when CONFIG_ACPI_APEI_SEA is defined. If not, it will return errors in the ghes_probe() and not continue. If the probe is failed, the ghes_sea_remove() also has no chance to be called. Hence, remove