RE: [PATCH v7] tpm: separate cmd_ready/go_idle from runtime_pm

2018-06-28 Thread Winkler, Tomas
> > On Wed, 2018-06-27 at 21:13 +, Winkler, Tomas wrote: > > Very well, I will remove the NESTED flag. though I have feeling you > > are shooting from the hip you didn't really read the code. > > Please there anyone who can review the code? > > Asking to change a minor thing in a patch doe

Re: [PATCH v7] tpm: separate cmd_ready/go_idle from runtime_pm

2018-06-28 Thread Jarkko Sakkinen
On Wed, 2018-06-27 at 21:13 +, Winkler, Tomas wrote: > Very well, I will remove the NESTED flag. though I have feeling you are > shooting from the hip you didn't really read the code. > Please there anyone who can review the code? Asking to change a minor thing in a patch does not really fit

RE: [PATCH v7] tpm: separate cmd_ready/go_idle from runtime_pm

2018-06-27 Thread Winkler, Tomas
> On Tue, 2018-06-26 at 21:15 +, Winkler, Tomas wrote: > > > Right now if I really put head into this I can understand the logic > > > but it is a complete mess. > > > > I think what is the mess is that we have a recursive call to > > tpm_transmit topped with retries. All other mess is just

Re: [PATCH v7] tpm: separate cmd_ready/go_idle from runtime_pm

2018-06-27 Thread Jarkko Sakkinen
On Tue, 2018-06-26 at 21:15 +, Winkler, Tomas wrote: > > Right now if I really put head into this I can understand the logic but it > > is a > > complete mess. > > I think what is the mess is that we have a recursive call to tpm_transmit > topped with retries. All other mess is just the resul

RE: [PATCH v7] tpm: separate cmd_ready/go_idle from runtime_pm

2018-06-26 Thread Winkler, Tomas
> > On Mon, 2018-06-25 at 19:24 +0300, Jarkko Sakkinen wrote: > > On Sun, 2018-06-24 at 23:52 +0300, Tomas Winkler wrote: > > > Fix tpm ptt initialization error: > > > tpm tpm0: A TPM error (378) occurred get tpm pcr allocation. > > > > > > We cannot use go_idle cmd_ready commands via runtime_pm

Re: [PATCH v7] tpm: separate cmd_ready/go_idle from runtime_pm

2018-06-26 Thread Jarkko Sakkinen
On Mon, 2018-06-25 at 18:50 +, Winkler, Tomas wrote: > > > > On Sun, 2018-06-24 at 23:52 +0300, Tomas Winkler wrote: > > > Fix tpm ptt initialization error: > > > tpm tpm0: A TPM error (378) occurred get tpm pcr allocation. > > > > > > We cannot use go_idle cmd_ready commands via runtime_pm h

RE: [PATCH v7] tpm: separate cmd_ready/go_idle from runtime_pm

2018-06-25 Thread Winkler, Tomas
> > On Sun, 2018-06-24 at 23:52 +0300, Tomas Winkler wrote: > > Fix tpm ptt initialization error: > > tpm tpm0: A TPM error (378) occurred get tpm pcr allocation. > > > > We cannot use go_idle cmd_ready commands via runtime_pm handles as > > with the introduction of localities this is no longer an

Re: [PATCH v7] tpm: separate cmd_ready/go_idle from runtime_pm

2018-06-25 Thread Jarkko Sakkinen
On Mon, 2018-06-25 at 19:24 +0300, Jarkko Sakkinen wrote: > On Sun, 2018-06-24 at 23:52 +0300, Tomas Winkler wrote: > > Fix tpm ptt initialization error: > > tpm tpm0: A TPM error (378) occurred get tpm pcr allocation. > > > > We cannot use go_idle cmd_ready commands via runtime_pm handles > > as

Re: [PATCH v7] tpm: separate cmd_ready/go_idle from runtime_pm

2018-06-25 Thread Jarkko Sakkinen
On Sun, 2018-06-24 at 23:52 +0300, Tomas Winkler wrote: > Fix tpm ptt initialization error: > tpm tpm0: A TPM error (378) occurred get tpm pcr allocation. > > We cannot use go_idle cmd_ready commands via runtime_pm handles > as with the introduction of localities this is no longer an optional > fe

[PATCH v7] tpm: separate cmd_ready/go_idle from runtime_pm

2018-06-24 Thread Tomas Winkler
Fix tpm ptt initialization error: tpm tpm0: A TPM error (378) occurred get tpm pcr allocation. We cannot use go_idle cmd_ready commands via runtime_pm handles as with the introduction of localities this is no longer an optional feature, while runtime pm can be not enabled. Though cmd_ready/go_idle