Re: [PATCH v7] watchdog: Add MOXA ART watchdog driver

2013-08-05 Thread Mark Rutland
On Fri, Aug 02, 2013 at 05:39:49PM +0100, Guenter Roeck wrote: > On 08/02/2013 04:41 AM, Mark Rutland wrote: > > On Mon, Jul 29, 2013 at 01:33:48PM +0100, Jonas Jensen wrote: > >> Add watchdog driver for MOXA ART SoCs. > >> > [ ... ] > >> + > >> + err = watchdog_register_device(&moxart_wdt->dev);

Re: [PATCH v7] watchdog: Add MOXA ART watchdog driver

2013-08-02 Thread Guenter Roeck
On 08/02/2013 04:41 AM, Mark Rutland wrote: On Mon, Jul 29, 2013 at 01:33:48PM +0100, Jonas Jensen wrote: Add watchdog driver for MOXA ART SoCs. [ ... ] + + err = watchdog_register_device(&moxart_wdt->dev); + if (unlikely(err)) + return err; This is a probe path. I

Re: [PATCH v7] watchdog: Add MOXA ART watchdog driver

2013-08-02 Thread Jonas Jensen
Hi Mark, Thanks for the replies. On 2 August 2013 13:41, Mark Rutland wrote: > It would be nice to have a fuller description here. I have tried to elaborate the commit message, please point out if it should be formatted differently. >> +Example: >> + >> + watchdog: watchdog@9850 { >> +

Re: [PATCH v7] watchdog: Add MOXA ART watchdog driver

2013-08-02 Thread Mark Rutland
On Mon, Jul 29, 2013 at 01:33:48PM +0100, Jonas Jensen wrote: > Add watchdog driver for MOXA ART SoCs. > It would be nice to have a fuller description here. > Signed-off-by: Jonas Jensen > --- > > Notes: > Changes since v6: > > 1. use local struct device *dev pointer, replace "&pd

Re: [PATCH v7] watchdog: Add MOXA ART watchdog driver

2013-07-29 Thread Guenter Roeck
On 07/29/2013 05:33 AM, Jonas Jensen wrote: Add watchdog driver for MOXA ART SoCs. Signed-off-by: Jonas Jensen Reviewed-by: Guenter Roeck -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH v7] watchdog: Add MOXA ART watchdog driver

2013-07-29 Thread Jonas Jensen
Add watchdog driver for MOXA ART SoCs. Signed-off-by: Jonas Jensen --- Notes: Changes since v6: 1. use local struct device *dev pointer, replace "&pdev->dev" with "dev" Applies to next-20130729 .../bindings/watchdog/moxa,moxart-watchdog.txt | 15 ++ drivers/watchdog/