* Sasha Levin (levinsasha...@gmail.com) wrote:
> On Mon, Oct 29, 2012 at 12:14 PM, Mathieu Desnoyers
> wrote:
> > * Sasha Levin (levinsasha...@gmail.com) wrote:
> >> On Mon, Oct 29, 2012 at 7:29 AM, Mathieu Desnoyers
> >> wrote:
> >> > * Sasha Levin (levinsasha...@gmail.com) wrote:
> >> >> +
>
On Mon, Oct 29, 2012 at 12:14 PM, Mathieu Desnoyers
wrote:
> * Sasha Levin (levinsasha...@gmail.com) wrote:
>> On Mon, Oct 29, 2012 at 7:29 AM, Mathieu Desnoyers
>> wrote:
>> > * Sasha Levin (levinsasha...@gmail.com) wrote:
>> >> +
>> >> + for (i = 0; i < sz; i++)
>> >> +
* Tejun Heo (t...@kernel.org) wrote:
> Hello,
>
> On Mon, Oct 29, 2012 at 12:14:12PM -0400, Mathieu Desnoyers wrote:
> > Most of the calls to this initialization function apply it on zeroed
> > memory (static/kzalloc'd...), which makes it useless. I'd actually be in
> > favor of removing those
Hello,
On Mon, Oct 29, 2012 at 12:14:12PM -0400, Mathieu Desnoyers wrote:
> Most of the calls to this initialization function apply it on zeroed
> memory (static/kzalloc'd...), which makes it useless. I'd actually be in
> favor of removing those redundant calls (as I pointed out in another
>
* Sasha Levin (levinsasha...@gmail.com) wrote:
> On Mon, Oct 29, 2012 at 7:29 AM, Mathieu Desnoyers
> wrote:
> > * Sasha Levin (levinsasha...@gmail.com) wrote:
> >> +
> >> + for (i = 0; i < sz; i++)
> >> + INIT_HLIST_HEAD([sz]);
> >
> > ouch. How did this work ? Has it been tested
On Mon, Oct 29, 2012 at 7:29 AM, Mathieu Desnoyers
wrote:
> * Sasha Levin (levinsasha...@gmail.com) wrote:
>> +
>> + for (i = 0; i < sz; i++)
>> + INIT_HLIST_HEAD([sz]);
>
> ouch. How did this work ? Has it been tested at all ?
>
> sz -> i
Funny enough, it works perfectly.
* Sasha Levin (levinsasha...@gmail.com) wrote:
> This hashtable implementation is using hlist buckets to provide a simple
> hashtable to prevent it from getting reimplemented all over the kernel.
>
> Signed-off-by: Sasha Levin
> ---
>
> Sorry for the long delay, I was busy with a bunch of
* Sasha Levin (levinsasha...@gmail.com) wrote:
This hashtable implementation is using hlist buckets to provide a simple
hashtable to prevent it from getting reimplemented all over the kernel.
Signed-off-by: Sasha Levin levinsasha...@gmail.com
---
Sorry for the long delay, I was busy with
On Mon, Oct 29, 2012 at 7:29 AM, Mathieu Desnoyers
mathieu.desnoy...@efficios.com wrote:
* Sasha Levin (levinsasha...@gmail.com) wrote:
+
+ for (i = 0; i sz; i++)
+ INIT_HLIST_HEAD(ht[sz]);
ouch. How did this work ? Has it been tested at all ?
sz - i
Funny enough, it
* Sasha Levin (levinsasha...@gmail.com) wrote:
On Mon, Oct 29, 2012 at 7:29 AM, Mathieu Desnoyers
mathieu.desnoy...@efficios.com wrote:
* Sasha Levin (levinsasha...@gmail.com) wrote:
+
+ for (i = 0; i sz; i++)
+ INIT_HLIST_HEAD(ht[sz]);
ouch. How did this work ? Has
Hello,
On Mon, Oct 29, 2012 at 12:14:12PM -0400, Mathieu Desnoyers wrote:
Most of the calls to this initialization function apply it on zeroed
memory (static/kzalloc'd...), which makes it useless. I'd actually be in
favor of removing those redundant calls (as I pointed out in another
email),
* Tejun Heo (t...@kernel.org) wrote:
Hello,
On Mon, Oct 29, 2012 at 12:14:12PM -0400, Mathieu Desnoyers wrote:
Most of the calls to this initialization function apply it on zeroed
memory (static/kzalloc'd...), which makes it useless. I'd actually be in
favor of removing those redundant
On Mon, Oct 29, 2012 at 12:14 PM, Mathieu Desnoyers
mathieu.desnoy...@efficios.com wrote:
* Sasha Levin (levinsasha...@gmail.com) wrote:
On Mon, Oct 29, 2012 at 7:29 AM, Mathieu Desnoyers
mathieu.desnoy...@efficios.com wrote:
* Sasha Levin (levinsasha...@gmail.com) wrote:
+
+ for (i =
* Sasha Levin (levinsasha...@gmail.com) wrote:
On Mon, Oct 29, 2012 at 12:14 PM, Mathieu Desnoyers
mathieu.desnoy...@efficios.com wrote:
* Sasha Levin (levinsasha...@gmail.com) wrote:
On Mon, Oct 29, 2012 at 7:29 AM, Mathieu Desnoyers
mathieu.desnoy...@efficios.com wrote:
* Sasha Levin
This hashtable implementation is using hlist buckets to provide a simple
hashtable to prevent it from getting reimplemented all over the kernel.
Signed-off-by: Sasha Levin
---
Sorry for the long delay, I was busy with a bunch of personal things.
Changes since v6:
- Use macros that point to
This hashtable implementation is using hlist buckets to provide a simple
hashtable to prevent it from getting reimplemented all over the kernel.
Signed-off-by: Sasha Levin levinsasha...@gmail.com
---
Sorry for the long delay, I was busy with a bunch of personal things.
Changes since v6:
- Use
16 matches
Mail list logo
