Re: [PATCH v7 04/10] drivers: qcom: rpmh: add RPMH helper functions

2018-05-14 Thread Lina Iyer
On Fri, May 11 2018 at 14:14 -0600, Doug Anderson wrote: Hi, On Fri, May 11, 2018 at 8:06 AM, Lina Iyer wrote: As I've said I haven't reviewed RPMh in any amount of detail and so perhaps I don't understand something. OK, I dug a little more and coded up something for you. Basically you're do

Re: [PATCH v7 04/10] drivers: qcom: rpmh: add RPMH helper functions

2018-05-11 Thread Doug Anderson
Hi, On Fri, May 11, 2018 at 8:06 AM, Lina Iyer wrote: >> As I've said I haven't reviewed RPMh in any amount of detail and so >> perhaps I don't understand something. >> >> OK, I dug a little more and coded up something for you. Basically >> you're doing a whole bunch of iteration / extra work he

Re: [PATCH v7 04/10] drivers: qcom: rpmh: add RPMH helper functions

2018-05-11 Thread Lina Iyer
Hi Doug, On Thu, May 10 2018 at 16:37 -0600, Doug Anderson wrote: Hi, On Tue, May 8, 2018 at 9:05 AM, wrote: On 2018-05-03 14:26, Doug Anderson wrote: Hi Doug, Hi, On Wed, May 2, 2018 at 12:37 PM, Lina Iyer wrote: +static struct rpmh_ctrlr rpmh_rsc[RPMH_MAX_CTRLR]; +static DEFINE_SPIN

Re: [PATCH v7 04/10] drivers: qcom: rpmh: add RPMH helper functions

2018-05-10 Thread Doug Anderson
Hi, On Tue, May 8, 2018 at 9:05 AM, wrote: > On 2018-05-03 14:26, Doug Anderson wrote: > Hi Doug, > > >> Hi, >> >> On Wed, May 2, 2018 at 12:37 PM, Lina Iyer wrote: >>> >>> +static struct rpmh_ctrlr rpmh_rsc[RPMH_MAX_CTRLR]; >>> +static DEFINE_SPINLOCK(rpmh_rsc_lock); >>> + >>> +static struct r

Re: [PATCH v7 04/10] drivers: qcom: rpmh: add RPMH helper functions

2018-05-08 Thread ilina
On 2018-05-03 14:26, Doug Anderson wrote: Hi Doug, Hi, On Wed, May 2, 2018 at 12:37 PM, Lina Iyer wrote: +static struct rpmh_ctrlr rpmh_rsc[RPMH_MAX_CTRLR]; +static DEFINE_SPINLOCK(rpmh_rsc_lock); + +static struct rpmh_ctrlr *get_rpmh_ctrlr(const struct device *dev) +{ + int i; +

Re: [PATCH v7 04/10] drivers: qcom: rpmh: add RPMH helper functions

2018-05-04 Thread Matthias Kaehlcke
On Thu, May 03, 2018 at 01:26:07PM -0700, Doug Anderson wrote: > Hi, > > On Wed, May 2, 2018 at 12:37 PM, Lina Iyer wrote: > > +static struct rpmh_ctrlr rpmh_rsc[RPMH_MAX_CTRLR]; > > +static DEFINE_SPINLOCK(rpmh_rsc_lock); > > + > > +static struct rpmh_ctrlr *get_rpmh_ctrlr(const struct device *d

Re: [PATCH v7 04/10] drivers: qcom: rpmh: add RPMH helper functions

2018-05-03 Thread Doug Anderson
Hi, On Wed, May 2, 2018 at 12:37 PM, Lina Iyer wrote: > +static struct rpmh_ctrlr rpmh_rsc[RPMH_MAX_CTRLR]; > +static DEFINE_SPINLOCK(rpmh_rsc_lock); > + > +static struct rpmh_ctrlr *get_rpmh_ctrlr(const struct device *dev) > +{ > + int i; > + struct rsc_drv *p, *drv = dev_get_drvdata

[PATCH v7 04/10] drivers: qcom: rpmh: add RPMH helper functions

2018-05-02 Thread Lina Iyer
Sending RPMH requests and waiting for response from the controller through a callback is common functionality across all platform drivers. To simplify drivers, add a library functions to create RPMH client and send resource state requests. rpmh_write() is a synchronous blocking call that can be us