Re: [PATCH v7 1/2] Kbuild: make DWARF version a choice

2021-02-06 Thread Mark Wielaard
Hi Nick, On Fri, Feb 05, 2021 at 01:18:11PM -0800, Nick Desaulniers wrote: > On Fri, Feb 5, 2021 at 4:49 AM Mark Wielaard wrote: > I guess I'm curious whether > https://bugzilla.redhat.com/show_bug.cgi?id=1922707 came up during the > mass rebuild of all of Fedora a few weeks ago? Assuming the

Re: [PATCH v7 1/2] Kbuild: make DWARF version a choice

2021-02-05 Thread Nick Desaulniers
On Fri, Feb 5, 2021 at 4:49 AM Mark Wielaard wrote: > > Hi Nick, > > On Thu, 2021-02-04 at 14:06 -0800, Nick Desaulniers wrote: > > On Thu, Feb 4, 2021 at 12:28 PM Mark Wielaard wrote: > > > I believe so yes, we did a mass-rebuild of all of Fedora a few weeks > > > back with a GCC11 pre-release

Re: [PATCH v7 1/2] Kbuild: make DWARF version a choice

2021-02-05 Thread Mark Wielaard
Hi Nick, On Thu, 2021-02-04 at 14:06 -0800, Nick Desaulniers wrote: > On Thu, Feb 4, 2021 at 12:28 PM Mark Wielaard wrote: > > I believe so yes, we did a mass-rebuild of all of Fedora a few weeks > > back with a GCC11 pre-release and did find some tools which weren't > > ready, but as far as I

Re: [PATCH v7 1/2] Kbuild: make DWARF version a choice

2021-02-04 Thread Fangrui Song
On 2021-02-04, Nick Desaulniers wrote: On Thu, Feb 4, 2021 at 12:28 PM Mark Wielaard wrote: On Thu, 2021-02-04 at 12:04 -0800, Nick Desaulniers wrote: > On Thu, Feb 4, 2021 at 11:56 AM Mark Wielaard wrote: > > I agree with Jakub. Now that GCC has defaulted to DWARF5 all the > > tools > >

Re: [PATCH v7 1/2] Kbuild: make DWARF version a choice

2021-02-04 Thread Nick Desaulniers
On Thu, Feb 4, 2021 at 12:28 PM Mark Wielaard wrote: > > On Thu, 2021-02-04 at 12:04 -0800, Nick Desaulniers wrote: > > On Thu, Feb 4, 2021 at 11:56 AM Mark Wielaard wrote: > > > I agree with Jakub. Now that GCC has defaulted to DWARF5 all the > > > tools > > > have adopted to the new default

Re: [PATCH v7 1/2] Kbuild: make DWARF version a choice

2021-02-04 Thread Mark Wielaard
On Thu, 2021-02-04 at 12:04 -0800, Nick Desaulniers wrote: > On Thu, Feb 4, 2021 at 11:56 AM Mark Wielaard wrote: > > I agree with Jakub. Now that GCC has defaulted to DWARF5 all the > > tools > > have adopted to the new default version. And DWARF5 has been out > > for > > "all of the tools" ?

Re: [PATCH v7 1/2] Kbuild: make DWARF version a choice

2021-02-04 Thread Nick Desaulniers
On Thu, Feb 4, 2021 at 11:56 AM Mark Wielaard wrote: > > On Thu, 2021-02-04 at 11:18 -0800, Nick Desaulniers wrote: > > On Thu, Feb 4, 2021 at 2:41 AM Mark Wielaard wrote: > > > On Fri, Jan 29, 2021 at 04:44:00PM -0800, Nick Desaulniers wrote: > > > > Modifies CONFIG_DEBUG_INFO_DWARF4 to be a

Re: [PATCH v7 1/2] Kbuild: make DWARF version a choice

2021-02-04 Thread Mark Wielaard
On Thu, 2021-02-04 at 11:18 -0800, Nick Desaulniers wrote: > On Thu, Feb 4, 2021 at 2:41 AM Mark Wielaard wrote: > > On Fri, Jan 29, 2021 at 04:44:00PM -0800, Nick Desaulniers wrote: > > > Modifies CONFIG_DEBUG_INFO_DWARF4 to be a member of a choice which is > > > the default. Does so in a way

Re: [PATCH v7 1/2] Kbuild: make DWARF version a choice

2021-02-04 Thread Nick Desaulniers
On Thu, Feb 4, 2021 at 2:41 AM Mark Wielaard wrote: > > Hi Nick, > > On Fri, Jan 29, 2021 at 04:44:00PM -0800, Nick Desaulniers wrote: > > Modifies CONFIG_DEBUG_INFO_DWARF4 to be a member of a choice which is > > the default. Does so in a way that's forward compatible with existing > > configs,

Re: [PATCH v7 1/2] Kbuild: make DWARF version a choice

2021-02-04 Thread Mark Wielaard
Hi Nick, On Fri, Jan 29, 2021 at 04:44:00PM -0800, Nick Desaulniers wrote: > Modifies CONFIG_DEBUG_INFO_DWARF4 to be a member of a choice which is > the default. Does so in a way that's forward compatible with existing > configs, and makes adding future versions more straightforward. > > GCC

Re: [PATCH v7 1/2] Kbuild: make DWARF version a choice

2021-02-03 Thread Nick Desaulniers
On Wed, Feb 3, 2021 at 4:30 PM Masahiro Yamada wrote: > > On Thu, Feb 4, 2021 at 8:16 AM Nick Desaulniers > wrote: > > > > On Wed, Feb 3, 2021 at 2:24 PM Masahiro Yamada wrote: > > > > > > On Sat, Jan 30, 2021 at 10:52 AM Nathan Chancellor > > > wrote: > > > > > > > > On Fri, Jan 29, 2021 at

Re: [PATCH v7 1/2] Kbuild: make DWARF version a choice

2021-02-03 Thread Nick Desaulniers
On Fri, Jan 29, 2021 at 5:52 PM Nathan Chancellor wrote: > > On Fri, Jan 29, 2021 at 04:44:00PM -0800, Nick Desaulniers wrote: > > Modifies CONFIG_DEBUG_INFO_DWARF4 to be a member of a choice which is > > the default. Does so in a way that's forward compatible with existing > > configs, and makes

Re: [PATCH v7 1/2] Kbuild: make DWARF version a choice

2021-02-03 Thread Nick Desaulniers
On Wed, Feb 3, 2021 at 7:32 PM Fangrui Song wrote: > > On 2021-02-04, Masahiro Yamada wrote: > >On Sat, Jan 30, 2021 at 10:52 AM Nathan Chancellor wrote: > >> > >> On Fri, Jan 29, 2021 at 04:44:00PM -0800, Nick Desaulniers wrote: > >> > Modifies CONFIG_DEBUG_INFO_DWARF4 to be a member of a

Re: [PATCH v7 1/2] Kbuild: make DWARF version a choice

2021-02-03 Thread Fangrui Song
On 2021-02-04, Masahiro Yamada wrote: On Sat, Jan 30, 2021 at 10:52 AM Nathan Chancellor wrote: On Fri, Jan 29, 2021 at 04:44:00PM -0800, Nick Desaulniers wrote: > Modifies CONFIG_DEBUG_INFO_DWARF4 to be a member of a choice which is > the default. Does so in a way that's forward compatible

Re: [PATCH v7 1/2] Kbuild: make DWARF version a choice

2021-02-03 Thread Masahiro Yamada
On Thu, Feb 4, 2021 at 8:16 AM Nick Desaulniers wrote: > > On Wed, Feb 3, 2021 at 2:24 PM Masahiro Yamada wrote: > > > > On Sat, Jan 30, 2021 at 10:52 AM Nathan Chancellor > > wrote: > > > > > > On Fri, Jan 29, 2021 at 04:44:00PM -0800, Nick Desaulniers wrote: > > > > Modifies

Re: [PATCH v7 1/2] Kbuild: make DWARF version a choice

2021-02-03 Thread Nick Desaulniers
On Wed, Feb 3, 2021 at 2:24 PM Masahiro Yamada wrote: > > On Sat, Jan 30, 2021 at 10:52 AM Nathan Chancellor wrote: > > > > On Fri, Jan 29, 2021 at 04:44:00PM -0800, Nick Desaulniers wrote: > > > Modifies CONFIG_DEBUG_INFO_DWARF4 to be a member of a choice which is > > > the default. Does so in

Re: [PATCH v7 1/2] Kbuild: make DWARF version a choice

2021-02-03 Thread Masahiro Yamada
On Thu, Feb 4, 2021 at 7:23 AM Masahiro Yamada wrote: > > On Sat, Jan 30, 2021 at 10:52 AM Nathan Chancellor wrote: > > > > On Fri, Jan 29, 2021 at 04:44:00PM -0800, Nick Desaulniers wrote: > > > Modifies CONFIG_DEBUG_INFO_DWARF4 to be a member of a choice which is > > > the default. Does so in

Re: [PATCH v7 1/2] Kbuild: make DWARF version a choice

2021-02-03 Thread Masahiro Yamada
On Sat, Jan 30, 2021 at 10:52 AM Nathan Chancellor wrote: > > On Fri, Jan 29, 2021 at 04:44:00PM -0800, Nick Desaulniers wrote: > > Modifies CONFIG_DEBUG_INFO_DWARF4 to be a member of a choice which is > > the default. Does so in a way that's forward compatible with existing > > configs, and

Re: [PATCH v7 1/2] Kbuild: make DWARF version a choice

2021-01-30 Thread Nathan Chancellor
On Fri, Jan 29, 2021 at 04:44:00PM -0800, Nick Desaulniers wrote: > Modifies CONFIG_DEBUG_INFO_DWARF4 to be a member of a choice which is > the default. Does so in a way that's forward compatible with existing > configs, and makes adding future versions more straightforward. > > GCC since ~4.8

[PATCH v7 1/2] Kbuild: make DWARF version a choice

2021-01-29 Thread Nick Desaulniers
Modifies CONFIG_DEBUG_INFO_DWARF4 to be a member of a choice which is the default. Does so in a way that's forward compatible with existing configs, and makes adding future versions more straightforward. GCC since ~4.8 has defaulted to this DWARF version implicitly. Suggested-by: Arvind Sankar