Re: [PATCH v7 1/2] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver

2019-01-30 Thread Boris Brezillon
On Wed, 30 Jan 2019 08:15:25 +0100 Marek Vasut wrote: > >> > So far as I know that HF is provided by Cypress only and > >> > any mass production product use the component which is provided by only > >> > one provider > >> > will be a big risk. > >> > > >> > Compare to HF, there are more provider

Re: [PATCH v7 1/2] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver

2019-01-29 Thread Marek Vasut
eert Uytterhoeven" >> , "Simon Horman" , >> julie...@mxic.com.tw, linux-kernel@vger.kernel.org, linux-renesas- >> s...@vger.kernel.org, linux-...@vger.kernel.org, >> sergei.shtyl...@cogentembedded.com, zhengxu...@mxic.com.tw >> >> Subject >> >> R

Re: [PATCH v7 1/2] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver

2019-01-28 Thread Marek Vasut
On 1/29/19 3:26 AM, masonccy...@mxic.com.tw wrote: > Hi Marek, Hi, >> >> "Marek Vasut" >> >> >> >> > +module_platform_driver(rpc_spi_driver); >> >> >> >> >> >> >> >> RPC is not a SPI controller, it's a SPI and HF controller. >> >> >> >> >> >> >> >> Also, how difficult will it be to add the HF

Re: [PATCH v7 1/2] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver

2019-01-28 Thread Marek Vasut
On 1/28/19 2:38 AM, masonccy...@mxic.com.tw wrote: > Hi Marek, Hi, >> "Marek Vasut" >> >> >> > +module_platform_driver(rpc_spi_driver); >> >> >> >> >> >> RPC is not a SPI controller, it's a SPI and HF controller. >> >> >> >> >> >> Also, how difficult will it be to add the HF support ? >> >> >

Re: [PATCH v7 1/2] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver

2019-01-26 Thread Marek Vasut
On 1/24/19 7:28 AM, masonccy...@mxic.com.tw wrote: > Hi Marek, Hi, >> "Marek Vasut" >> 2019/01/24 上午 11:14 >> >> >> >> > +module_platform_driver(rpc_spi_driver); >> >> >> >> RPC is not a SPI controller, it's a SPI and HF controller. >> >> >> >> Also, how difficult will it be to add the HF

Re: [PATCH v7 1/2] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver

2019-01-24 Thread Sergei Shtylyov
On 01/24/2019 05:23 AM, masonccy...@mxic.com.tw wrote: >> [...] >> >> > +module_platform_driver(rpc_spi_driver); >> >> RPC is not a SPI controller, it's a SPI and HF controller. >> >> Also, how difficult will it be to add the HF support ? > > One of my customers needs RPC SPI driver for our

Re: [PATCH v7 1/2] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver

2019-01-24 Thread Sergei Shtylyov
On 01/24/2019 05:06 AM, masonccy...@mxic.com.tw wrote: >> > +// SPDX-License-Identifier: GPL-2.0 >> > +// >> > +// Copyright (C) 2018 ~ 2019 Renesas Solutions Corp. >> > +// Copyright (C) 2018 Macronix International Co., Ltd. >> > +// >> > +// R-Car Gen3 RPC-IF SPI/QSPI/Octa driver >> >>Do we

Re: [PATCH v7 1/2] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver

2019-01-24 Thread Sergei Shtylyov
On 01/24/2019 05:06 AM, masonccy...@mxic.com.tw wrote: >> > +// SPDX-License-Identifier: GPL-2.0 >> > +// >> > +// Copyright (C) 2018 ~ 2019 Renesas Solutions Corp. >> > +// Copyright (C) 2018 Macronix International Co., Ltd. >> > +// >> > +// R-Car Gen3 RPC-IF SPI/QSPI/Octa driver >> >>Do we

Re: [PATCH v7 1/2] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver

2019-01-24 Thread Geert Uytterhoeven
Hi Mason, On Thu, Jan 24, 2019 at 3:07 AM wrote: > > "Sergei Shtylyov" > > 2019/01/24 上午 02:04 > > > +static const struct of_device_id rpc_spi_of_ids[] = { > > > + { .compatible = "renesas,r8a77995-rpc", }, > > > >Why (if it has no differences with the generic gen3 value below)? > >

Re: [PATCH v7 1/2] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver

2019-01-23 Thread Marek Vasut
On 1/24/19 3:23 AM, masonccy...@mxic.com.tw wrote: > Hi Marek, Hi, >> "Marek Vasut" >> 2019/01/24 上午 09:54 >> >> >> > +#define RPC_CMNCR      0x   // R/W >> >> Is there any reason for using those horrible C++ comments ? > > By Mark's comments for the SPDX header needs to be C++ style and >

Re: [PATCH v7 1/2] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver

2019-01-23 Thread Marek Vasut
On 1/23/19 8:09 AM, Mason Yang wrote: > Add a driver for Renesas R-Car Gen3 RPC-IF SPI controller. > > Signed-off-by: Mason Yang > Signed-off-by: Sergei Shtylyov [...] > +#define RPC_CMNCR0x // R/W Is there any reason for using those horrible C++ comments ? [...] >

Re: [PATCH v7 1/2] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver

2019-01-23 Thread Sergei Shtylyov
Hello! On 01/23/2019 10:09 AM, Mason Yang wrote: > Add a driver for Renesas R-Car Gen3 RPC-IF SPI controller. > > Signed-off-by: Mason Yang > Signed-off-by: Sergei Shtylyov [...] > diff --git a/drivers/spi/spi-renesas-rpc.c b/drivers/spi/spi-renesas-rpc.c > new file mode 100644 > index

[PATCH v7 1/2] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver

2019-01-22 Thread Mason Yang
Add a driver for Renesas R-Car Gen3 RPC-IF SPI controller. Signed-off-by: Mason Yang Signed-off-by: Sergei Shtylyov --- drivers/spi/Kconfig | 6 + drivers/spi/Makefile | 1 + drivers/spi/spi-renesas-rpc.c | 805 ++ 3 files changed,