Re: [PATCH v7 1/5] perf report: properly handle branch count in match_chain

2017-10-23 Thread Andi Kleen
Milian Wolff writes: > bi = sample__resolve_bstack(sample, al); > diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c > index 94d8f1ccedd9..e54741308e6c 100644 > --- a/tools/perf/util/machine.c > +++ b/tools/perf/util/machine.c > @@ -1824,6

Re: [PATCH v7 1/5] perf report: properly handle branch count in match_chain

2017-10-23 Thread Andi Kleen
Milian Wolff writes: > bi = sample__resolve_bstack(sample, al); > diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c > index 94d8f1ccedd9..e54741308e6c 100644 > --- a/tools/perf/util/machine.c > +++ b/tools/perf/util/machine.c > @@ -1824,6 +1824,8 @@ struct

Re: [PATCH v7 1/5] perf report: properly handle branch count in match_chain

2017-10-23 Thread Milian Wolff
On Montag, 23. Oktober 2017 17:15:11 CEST Andi Kleen wrote: > Milian Wolff writes: > > perf record -b --call-graph dwarf > > perf report --branch-history --no-children --stdio > > > > I see predicted and iter values as before, so I think nothing is breaking. > > But I'm

Re: [PATCH v7 1/5] perf report: properly handle branch count in match_chain

2017-10-23 Thread Milian Wolff
On Montag, 23. Oktober 2017 17:15:11 CEST Andi Kleen wrote: > Milian Wolff writes: > > perf record -b --call-graph dwarf > > perf report --branch-history --no-children --stdio > > > > I see predicted and iter values as before, so I think nothing is breaking. > > But I'm somewhat unsure. Can

Re: [PATCH v7 1/5] perf report: properly handle branch count in match_chain

2017-10-23 Thread Andi Kleen
Milian Wolff writes: > > perf record -b --call-graph dwarf > perf report --branch-history --no-children --stdio > > I see predicted and iter values as before, so I think nothing is breaking. > But > I'm somewhat unsure. Can someone paste an example source code and the

Re: [PATCH v7 1/5] perf report: properly handle branch count in match_chain

2017-10-23 Thread Andi Kleen
Milian Wolff writes: > > perf record -b --call-graph dwarf > perf report --branch-history --no-children --stdio > > I see predicted and iter values as before, so I think nothing is breaking. > But > I'm somewhat unsure. Can someone paste an example source code and the perf > commands to get

Re: [PATCH v7 1/5] perf report: properly handle branch count in match_chain

2017-10-19 Thread Milian Wolff
On Donnerstag, 19. Oktober 2017 13:38:32 CEST Milian Wolff wrote: > Some of the code paths I introduced before returned too early > without running the code to handle a node's branch count. > By refactoring match_chain to only have one exit point, this > can be remedied. Note: I tested this with

Re: [PATCH v7 1/5] perf report: properly handle branch count in match_chain

2017-10-19 Thread Milian Wolff
On Donnerstag, 19. Oktober 2017 13:38:32 CEST Milian Wolff wrote: > Some of the code paths I introduced before returned too early > without running the code to handle a node's branch count. > By refactoring match_chain to only have one exit point, this > can be remedied. Note: I tested this with

[PATCH v7 1/5] perf report: properly handle branch count in match_chain

2017-10-19 Thread Milian Wolff
Some of the code paths I introduced before returned too early without running the code to handle a node's branch count. By refactoring match_chain to only have one exit point, this can be remedied. Cc: Arnaldo Carvalho de Melo Cc: David Ahern Cc: Namhyung Kim

[PATCH v7 1/5] perf report: properly handle branch count in match_chain

2017-10-19 Thread Milian Wolff
Some of the code paths I introduced before returned too early without running the code to handle a node's branch count. By refactoring match_chain to only have one exit point, this can be remedied. Cc: Arnaldo Carvalho de Melo Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Yao Jin