Re: [PATCH v7 1/9] nvmem: Add a simple NVMEM framework for nvmem providers

2015-07-13 Thread Philipp Zabel
Hi Srinivas, Am Freitag, den 10.07.2015, 10:44 +0100 schrieb Srinivas Kandagatla: > This patch adds just providers part of the framework just to enable easy > review. [...] > +/** > + * nvmem_register() - Register a nvmem device for given nvmem_config. > + * Also creates an binary entry in

Re: [PATCH v7 1/9] nvmem: Add a simple NVMEM framework for nvmem providers

2015-07-13 Thread Philipp Zabel
Hi Srinivas, Am Freitag, den 10.07.2015, 10:44 +0100 schrieb Srinivas Kandagatla: This patch adds just providers part of the framework just to enable easy review. [...] +/** + * nvmem_register() - Register a nvmem device for given nvmem_config. + * Also creates an binary entry in

Re: [PATCH v7 1/9] nvmem: Add a simple NVMEM framework for nvmem providers

2015-07-10 Thread Srinivas Kandagatla
Thanks for quick review, On 10/07/15 11:29, Joe Perches wrote: On Fri, 2015-07-10 at 10:44 +0100, Srinivas Kandagatla wrote: This patch adds just providers part of the framework just to enable easy review. Trivial notes: Will fix all them. --srini diff --git a/drivers/nvmem/core.c

Re: [PATCH v7 1/9] nvmem: Add a simple NVMEM framework for nvmem providers

2015-07-10 Thread Joe Perches
On Fri, 2015-07-10 at 10:44 +0100, Srinivas Kandagatla wrote: > This patch adds just providers part of the framework just to enable easy > review. Trivial notes: > diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c > +struct nvmem_device { > + const char *name; > +

[PATCH v7 1/9] nvmem: Add a simple NVMEM framework for nvmem providers

2015-07-10 Thread Srinivas Kandagatla
This patch adds just providers part of the framework just to enable easy review. Up until now, NVMEM drivers like eeprom were stored in drivers/misc, where they all had to duplicate pretty much the same code to register a sysfs file, allow in-kernel users to access the content of the devices they

[PATCH v7 1/9] nvmem: Add a simple NVMEM framework for nvmem providers

2015-07-10 Thread Srinivas Kandagatla
This patch adds just providers part of the framework just to enable easy review. Up until now, NVMEM drivers like eeprom were stored in drivers/misc, where they all had to duplicate pretty much the same code to register a sysfs file, allow in-kernel users to access the content of the devices they

Re: [PATCH v7 1/9] nvmem: Add a simple NVMEM framework for nvmem providers

2015-07-10 Thread Joe Perches
On Fri, 2015-07-10 at 10:44 +0100, Srinivas Kandagatla wrote: This patch adds just providers part of the framework just to enable easy review. Trivial notes: diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c +struct nvmem_device { + const char *name; + struct

Re: [PATCH v7 1/9] nvmem: Add a simple NVMEM framework for nvmem providers

2015-07-10 Thread Srinivas Kandagatla
Thanks for quick review, On 10/07/15 11:29, Joe Perches wrote: On Fri, 2015-07-10 at 10:44 +0100, Srinivas Kandagatla wrote: This patch adds just providers part of the framework just to enable easy review. Trivial notes: Will fix all them. --srini diff --git a/drivers/nvmem/core.c