Re: [PATCH v7 11/22] Replace ext2_clear_xip_target with dax_clear_blocks

2014-04-10 Thread Jan Kara
On Thu 10-04-14 10:16:30, Matthew Wilcox wrote: > On Wed, Apr 09, 2014 at 11:46:44AM +0200, Jan Kara wrote: > > Another day, some more review ;) Comments below. > > I'm really grateful for all this review! It's killing me, though ;-) Yeah, I know that feeling. :) > > > +int

Re: [PATCH v7 11/22] Replace ext2_clear_xip_target with dax_clear_blocks

2014-04-10 Thread Matthew Wilcox
On Wed, Apr 09, 2014 at 11:46:44AM +0200, Jan Kara wrote: > Another day, some more review ;) Comments below. I'm really grateful for all this review! It's killing me, though ;-) > > +int dax_clear_blocks(struct inode *inode, sector_t block, long size) > > +{ > > + struct block_device *bdev

Re: [PATCH v7 11/22] Replace ext2_clear_xip_target with dax_clear_blocks

2014-04-10 Thread Matthew Wilcox
On Wed, Apr 09, 2014 at 11:46:44AM +0200, Jan Kara wrote: Another day, some more review ;) Comments below. I'm really grateful for all this review! It's killing me, though ;-) +int dax_clear_blocks(struct inode *inode, sector_t block, long size) +{ + struct block_device *bdev =

Re: [PATCH v7 11/22] Replace ext2_clear_xip_target with dax_clear_blocks

2014-04-10 Thread Jan Kara
On Thu 10-04-14 10:16:30, Matthew Wilcox wrote: On Wed, Apr 09, 2014 at 11:46:44AM +0200, Jan Kara wrote: Another day, some more review ;) Comments below. I'm really grateful for all this review! It's killing me, though ;-) Yeah, I know that feeling. :) +int dax_clear_blocks(struct

Re: [PATCH v7 11/22] Replace ext2_clear_xip_target with dax_clear_blocks

2014-04-09 Thread Jan Kara
On Sun 23-03-14 15:08:37, Matthew Wilcox wrote: > This is practically generic code; other filesystems will want to call > it from other places, but there's nothing ext2-specific about it. > > Make it a little more generic by allowing it to take a count of the number > of bytes to zero rather than

Re: [PATCH v7 11/22] Replace ext2_clear_xip_target with dax_clear_blocks

2014-04-09 Thread Jan Kara
On Sun 23-03-14 15:08:37, Matthew Wilcox wrote: This is practically generic code; other filesystems will want to call it from other places, but there's nothing ext2-specific about it. Make it a little more generic by allowing it to take a count of the number of bytes to zero rather than

[PATCH v7 11/22] Replace ext2_clear_xip_target with dax_clear_blocks

2014-03-23 Thread Matthew Wilcox
This is practically generic code; other filesystems will want to call it from other places, but there's nothing ext2-specific about it. Make it a little more generic by allowing it to take a count of the number of bytes to zero rather than fixing it to a single page. Thanks to Dave Hansen for

[PATCH v7 11/22] Replace ext2_clear_xip_target with dax_clear_blocks

2014-03-23 Thread Matthew Wilcox
This is practically generic code; other filesystems will want to call it from other places, but there's nothing ext2-specific about it. Make it a little more generic by allowing it to take a count of the number of bytes to zero rather than fixing it to a single page. Thanks to Dave Hansen for