Re: [PATCH v7 14/34] i2c: tegra: Clean up probe function

2020-09-21 Thread Thierry Reding
On Thu, Sep 17, 2020 at 06:02:26PM +0300, Dmitry Osipenko wrote: > 17.09.2020 15:37, Thierry Reding пишет: > ... > >> + /* interrupt will be enabled during of transfer time */ > >> + irq_set_status_flags(i2c_dev->irq, IRQ_NOAUTOEN); > > >

Re: [PATCH v7 14/34] i2c: tegra: Clean up probe function

2020-09-21 Thread Thierry Reding
On Thu, Sep 17, 2020 at 04:46:45PM +0300, Andy Shevchenko wrote: > On Thu, Sep 17, 2020 at 3:37 PM Thierry Reding > wrote: > > On Wed, Sep 09, 2020 at 01:39:46AM +0300, Dmitry Osipenko wrote: > > ... > > > > + ret = devm_request_irq(>dev, i2c_dev->irq, tegra_i2c_isr, > > > +

Re: [PATCH v7 14/34] i2c: tegra: Clean up probe function

2020-09-21 Thread Thierry Reding
On Wed, 09 Sep 2020 01:39:46 +0300, Dmitry Osipenko wrote: > The driver's probe function code is a bit difficult to read. This patch > reorders code of the probe function, forming groups of code that are easy > to work with. The probe tear-down order now matches the driver-removal > order. > >

Re: [PATCH v7 14/34] i2c: tegra: Clean up probe function

2020-09-17 Thread Dmitry Osipenko
17.09.2020 15:37, Thierry Reding пишет: ... >> +/* interrupt will be enabled during of transfer time */ >> +irq_set_status_flags(i2c_dev->irq, IRQ_NOAUTOEN); >> +ret = devm_request_irq(>dev, i2c_dev->irq, tegra_i2c_isr, >> +

Re: [PATCH v7 14/34] i2c: tegra: Clean up probe function

2020-09-17 Thread Andy Shevchenko
On Thu, Sep 17, 2020 at 3:37 PM Thierry Reding wrote: > On Wed, Sep 09, 2020 at 01:39:46AM +0300, Dmitry Osipenko wrote: ... > > + ret = devm_request_irq(>dev, i2c_dev->irq, tegra_i2c_isr, > > +IRQF_NO_SUSPEND, dev_name(>dev), > > +

Re: [PATCH v7 14/34] i2c: tegra: Clean up probe function

2020-09-17 Thread Thierry Reding
On Wed, Sep 09, 2020 at 01:39:46AM +0300, Dmitry Osipenko wrote: > The driver's probe function code is a bit difficult to read. This patch > reorders code of the probe function, forming groups of code that are easy > to work with. The probe tear-down order now matches the driver-removal > order. >

[PATCH v7 14/34] i2c: tegra: Clean up probe function

2020-09-08 Thread Dmitry Osipenko
The driver's probe function code is a bit difficult to read. This patch reorders code of the probe function, forming groups of code that are easy to work with. The probe tear-down order now matches the driver-removal order. Signed-off-by: Dmitry Osipenko --- drivers/i2c/busses/i2c-tegra.c | 100