Re: [PATCH v7 17/34] i2c: tegra: Remove outdated barrier()

2020-09-21 Thread Thierry Reding
On Wed, 09 Sep 2020 01:39:49 +0300, Dmitry Osipenko wrote: > The barrier() was intended to reduce possibility of racing with the > interrupt handler, but driver's code evolved significantly and today's > driver enables interrupt only when it waits for completion notification. > Hence barrier() has

Re: [PATCH v7 17/34] i2c: tegra: Remove outdated barrier()

2020-09-17 Thread Thierry Reding
On Wed, Sep 09, 2020 at 01:39:49AM +0300, Dmitry Osipenko wrote: > The barrier() was intended to reduce possibility of racing with the > interrupt handler, but driver's code evolved significantly and today's > driver enables interrupt only when it waits for completion notification. > Hence

[PATCH v7 17/34] i2c: tegra: Remove outdated barrier()

2020-09-08 Thread Dmitry Osipenko
The barrier() was intended to reduce possibility of racing with the interrupt handler, but driver's code evolved significantly and today's driver enables interrupt only when it waits for completion notification. Hence barrier() has no good use anymore, let's remove it. Reviewed-by: MichaƂ