Re: [PATCH v7 2/2] drivers/misc: Add Aspeed P2A control driver

2019-03-28 Thread Patrick Venture
On Wed, Mar 27, 2019 at 11:52 PM Greg KH wrote: > > On Wed, Mar 27, 2019 at 12:01:50PM -0700, Patrick Venture wrote: > > On Wed, Mar 27, 2019 at 11:54 AM Greg KH wrote: > > > > > > On Wed, Mar 27, 2019 at 11:44:36AM -0700, Patrick Venture wrote: > > > > On Wed, Mar 27, 2019 at 11:28 AM Greg KH

Re: [PATCH v7 2/2] drivers/misc: Add Aspeed P2A control driver

2019-03-28 Thread Greg KH
On Wed, Mar 27, 2019 at 12:01:50PM -0700, Patrick Venture wrote: > On Wed, Mar 27, 2019 at 11:54 AM Greg KH wrote: > > > > On Wed, Mar 27, 2019 at 11:44:36AM -0700, Patrick Venture wrote: > > > On Wed, Mar 27, 2019 at 11:28 AM Greg KH > > > wrote: > > > > > > > > On Tue, Mar 12, 2019 at

Re: [PATCH v7 2/2] drivers/misc: Add Aspeed P2A control driver

2019-03-27 Thread Patrick Venture
On Wed, Mar 27, 2019 at 12:01 PM Patrick Venture wrote: > > On Wed, Mar 27, 2019 at 11:54 AM Greg KH wrote: > > > > On Wed, Mar 27, 2019 at 11:44:36AM -0700, Patrick Venture wrote: > > > On Wed, Mar 27, 2019 at 11:28 AM Greg KH > > > wrote: > > > > > > > > On Tue, Mar 12, 2019 at 09:31:01AM

Re: [PATCH v7 2/2] drivers/misc: Add Aspeed P2A control driver

2019-03-27 Thread Patrick Venture
On Wed, Mar 27, 2019 at 11:54 AM Greg KH wrote: > > On Wed, Mar 27, 2019 at 11:44:36AM -0700, Patrick Venture wrote: > > On Wed, Mar 27, 2019 at 11:28 AM Greg KH wrote: > > > > > > On Tue, Mar 12, 2019 at 09:31:01AM -0700, Patrick Venture wrote: > > > > + phys_addr_t mem_base; > > > > > > Is

Re: [PATCH v7 2/2] drivers/misc: Add Aspeed P2A control driver

2019-03-27 Thread Greg KH
On Wed, Mar 27, 2019 at 11:44:36AM -0700, Patrick Venture wrote: > On Wed, Mar 27, 2019 at 11:28 AM Greg KH wrote: > > > > On Tue, Mar 12, 2019 at 09:31:01AM -0700, Patrick Venture wrote: > > > + phys_addr_t mem_base; > > > > Is this really a 32bit value? > > It's going to be a 32-bit value

Re: [PATCH v7 2/2] drivers/misc: Add Aspeed P2A control driver

2019-03-27 Thread Patrick Venture
On Wed, Mar 27, 2019 at 11:28 AM Greg KH wrote: > > On Tue, Mar 12, 2019 at 09:31:01AM -0700, Patrick Venture wrote: > > + phys_addr_t mem_base; > > Is this really a 32bit value? It's going to be a 32-bit value if this is in the dts for one of the correspondingly supported aspeed models. >

Re: [PATCH v7 2/2] drivers/misc: Add Aspeed P2A control driver

2019-03-27 Thread Greg KH
On Tue, Mar 12, 2019 at 09:31:01AM -0700, Patrick Venture wrote: > + phys_addr_t mem_base; Is this really a 32bit value? Your ioctl thinks it is: > +struct aspeed_p2a_ctrl_mapping { > + __u32 addr; Does this driver not work on a 64bit kernel? > + __u32 length; > + __u32 flags;

[PATCH v7 2/2] drivers/misc: Add Aspeed P2A control driver

2019-03-12 Thread Patrick Venture
The ASPEED AST2400, and AST2500 in some configurations include a PCI-to-AHB MMIO bridge. This bridge allows a server to read and write in the BMC's physical address space. This feature is especially useful when using this bridge to send large files to the BMC. The host may use this to send down