Re: [PATCH v7 2/2] drm/bridge: Introduce LT8912B DSI to HDMI bridge

2021-03-23 Thread Robert Foss
Alright, I think the best way forward is to remove the polled HPD support. Don't forget to update flags and function pointers. With that, feel free to add my r-b. Reviewed-by: Robert Foss

Re: [PATCH v7 2/2] drm/bridge: Introduce LT8912B DSI to HDMI bridge

2021-03-23 Thread Robert Foss
> > Are you saying that pin 63 never is high, or that an irq/isr routine > > isn't getting executed? > > > > > When reading the value of the HPD pin, I always get 1 (and no > > > transition occurs when plugging / unplugging a cable). > > > The HPD IRQ is done on the HDMI connector driver [5]. > >

Re: [PATCH v7 2/2] drm/bridge: Introduce LT8912B DSI to HDMI bridge

2021-03-23 Thread Adrien Grassein
Le mar. 23 mars 2021 à 15:16, Adrien Grassein a écrit : > > Le mar. 23 mars 2021 à 15:07, Robert Foss a écrit : > > > > > > > > > > > > > > > +static enum drm_connector_status > > > > > > > lt8912_check_cable_status(struct lt8912 *lt) > > > > > > > +{ > > > > > > > + int ret; > > > > > >

Re: [PATCH v7 2/2] drm/bridge: Introduce LT8912B DSI to HDMI bridge

2021-03-23 Thread Adrien Grassein
Le mar. 23 mars 2021 à 15:07, Robert Foss a écrit : > > > > > > > > > > > > +static enum drm_connector_status lt8912_check_cable_status(struct > > > > > > lt8912 *lt) > > > > > > +{ > > > > > > + int ret; > > > > > > + unsigned int reg_val; > > > > > > + > > > > > > + ret =

Re: [PATCH v7 2/2] drm/bridge: Introduce LT8912B DSI to HDMI bridge

2021-03-23 Thread Robert Foss
> > > > > > > > > +static enum drm_connector_status lt8912_check_cable_status(struct > > > > > lt8912 *lt) > > > > > +{ > > > > > + int ret; > > > > > + unsigned int reg_val; > > > > > + > > > > > + ret = regmap_read(lt->regmap[I2C_MAIN], 0xC1, _val); > > > > > + if (ret)

Re: [PATCH v7 2/2] drm/bridge: Introduce LT8912B DSI to HDMI bridge

2021-03-23 Thread Adrien Grassein
Le mar. 23 mars 2021 à 11:42, Robert Foss a écrit : > > On Tue, 23 Mar 2021 at 11:01, Adrien Grassein > wrote: > > > > Hey Robert, > > > > Thanks for the update. > > > > Le mar. 23 mars 2021 à 10:10, Robert Foss a écrit : > > > > > > Hey Adrien, > > > > > > Sorry about the slow reply, but I

Re: [PATCH v7 2/2] drm/bridge: Introduce LT8912B DSI to HDMI bridge

2021-03-23 Thread Robert Foss
On Tue, 23 Mar 2021 at 11:01, Adrien Grassein wrote: > > Hey Robert, > > Thanks for the update. > > Le mar. 23 mars 2021 à 10:10, Robert Foss a écrit : > > > > Hey Adrien, > > > > Sorry about the slow reply, but I just received the documentation from > > the vendor. So let's dig in to the HPD

Re: [PATCH v7 2/2] drm/bridge: Introduce LT8912B DSI to HDMI bridge

2021-03-23 Thread Adrien Grassein
Hey Robert, Thanks for the update. Le mar. 23 mars 2021 à 10:10, Robert Foss a écrit : > > Hey Adrien, > > Sorry about the slow reply, but I just received the documentation from > the vendor. So let's dig in to the HPD issue. No problem :) > > > +static enum drm_connector_status

Re: [PATCH v7 2/2] drm/bridge: Introduce LT8912B DSI to HDMI bridge

2021-03-23 Thread Robert Foss
Hey Adrien, Sorry about the slow reply, but I just received the documentation from the vendor. So let's dig in to the HPD issue. > +static enum drm_connector_status lt8912_check_cable_status(struct lt8912 *lt) > +{ > + int ret; > + unsigned int reg_val; > + > + ret =

[PATCH v7 2/2] drm/bridge: Introduce LT8912B DSI to HDMI bridge

2021-03-08 Thread Adrien Grassein
Lontium LT8912B is a DSI to HDMI bridge. Signed-off-by: Adrien Grassein Reported-by: kernel test robot --- MAINTAINERS | 1 + drivers/gpu/drm/bridge/Kconfig | 14 + drivers/gpu/drm/bridge/Makefile | 1 +