Re: [PATCH v7 2/7] arm64: Add more test functions to insn.c

2015-06-29 Thread David Long
On 06/29/15 13:23, Steve Capper wrote: Hi David, Some comments below. On 15 June 2015 at 20:07, David Long wrote: From: "David A. Long" Certain instructions are hard to execute correctly out-of-line (as in kprobes). Test functions are added to insn.[hc] to identify these. The instructions

Re: [PATCH v7 2/7] arm64: Add more test functions to insn.c

2015-06-29 Thread Steve Capper
Hi David, Some comments below. On 15 June 2015 at 20:07, David Long wrote: > From: "David A. Long" > > Certain instructions are hard to execute correctly out-of-line (as in > kprobes). Test functions are added to insn.[hc] to identify these. The > instructions include any that use PC-relative

Re: [PATCH v7 2/7] arm64: Add more test functions to insn.c

2015-06-29 Thread Steve Capper
Hi David, Some comments below. On 15 June 2015 at 20:07, David Long dave.l...@linaro.org wrote: From: David A. Long dave.l...@linaro.org Certain instructions are hard to execute correctly out-of-line (as in kprobes). Test functions are added to insn.[hc] to identify these. The instructions

Re: [PATCH v7 2/7] arm64: Add more test functions to insn.c

2015-06-29 Thread David Long
On 06/29/15 13:23, Steve Capper wrote: Hi David, Some comments below. On 15 June 2015 at 20:07, David Long dave.l...@linaro.org wrote: From: David A. Long dave.l...@linaro.org Certain instructions are hard to execute correctly out-of-line (as in kprobes). Test functions are added to

[PATCH v7 2/7] arm64: Add more test functions to insn.c

2015-06-15 Thread David Long
From: "David A. Long" Certain instructions are hard to execute correctly out-of-line (as in kprobes). Test functions are added to insn.[hc] to identify these. The instructions include any that use PC-relative addressing, change the PC, or change interrupt masking. For efficiency and simplicity

[PATCH v7 2/7] arm64: Add more test functions to insn.c

2015-06-15 Thread David Long
From: David A. Long dave.l...@linaro.org Certain instructions are hard to execute correctly out-of-line (as in kprobes). Test functions are added to insn.[hc] to identify these. The instructions include any that use PC-relative addressing, change the PC, or change interrupt masking. For