Re: [PATCH v7 24/34] i2c: tegra: Factor out packet header setup from tegra_i2c_xfer_msg()

2020-09-21 Thread Thierry Reding
On Wed, 09 Sep 2020 01:39:56 +0300, Dmitry Osipenko wrote: > The code related to packet header setting up is a bit messy and makes > tegra_i2c_xfer_msg() more difficult to read than it could be. Let's > factor the packet header setup from tegra_i2c_xfer_msg() into separate > function in order to

Re: [PATCH v7 24/34] i2c: tegra: Factor out packet header setup from tegra_i2c_xfer_msg()

2020-09-17 Thread Thierry Reding
On Wed, Sep 09, 2020 at 01:39:56AM +0300, Dmitry Osipenko wrote: > The code related to packet header setting up is a bit messy and makes > tegra_i2c_xfer_msg() more difficult to read than it could be. Let's > factor the packet header setup from tegra_i2c_xfer_msg() into separate > function in

[PATCH v7 24/34] i2c: tegra: Factor out packet header setup from tegra_i2c_xfer_msg()

2020-09-08 Thread Dmitry Osipenko
The code related to packet header setting up is a bit messy and makes tegra_i2c_xfer_msg() more difficult to read than it could be. Let's factor the packet header setup from tegra_i2c_xfer_msg() into separate function in order to make code easier to read and follow. Reviewed-by: Michał Mirosław