Re: [PATCH v7 3/4] perf,x86: add Intel RAPL PMU support

2013-11-30 Thread Vince Weaver
On Sat, 30 Nov 2013, Stephane Eranian wrote: > Ok, I have added PP1 now and it works fine on my HSW desktop. > What I want to know now is what is this map to on servers? > And on clients, it is always mapped to the GFX. If so, then > we can use a more specific name: power/energy-gfx/ I don't

Re: [PATCH v7 3/4] perf,x86: add Intel RAPL PMU support

2013-11-30 Thread Vince Weaver
On Sat, 30 Nov 2013, Stephane Eranian wrote: Ok, I have added PP1 now and it works fine on my HSW desktop. What I want to know now is what is this map to on servers? And on clients, it is always mapped to the GFX. If so, then we can use a more specific name: power/energy-gfx/ I don't know if

Re: [PATCH v7 3/4] perf,x86: add Intel RAPL PMU support

2013-11-29 Thread Stephane Eranian
Vince, Ok, I have added PP1 now and it works fine on my HSW desktop. What I want to know now is what is this map to on servers? And on clients, it is always mapped to the GFX. If so, then we can use a more specific name: power/energy-gfx/ I will send a patch soon. Thanks. On Fri, Nov 29, 2013

Re: [PATCH v7 3/4] perf,x86: add Intel RAPL PMU support

2013-11-29 Thread Borislav Petkov
On Fri, Nov 29, 2013 at 09:09:46PM +0100, Stephane Eranian wrote: > > So in theory it would be harmless to export the values even if not > > supported. What is the worst failure mode? That somehow a recent CPU > > doesn't support the MSR and we get a GPF when trying to access it? > > > Yes. I

Re: [PATCH v7 3/4] perf,x86: add Intel RAPL PMU support

2013-11-29 Thread Stephane Eranian
On Fri, Nov 29, 2013 at 8:16 PM, Vince Weaver wrote: > On Thu, 28 Nov 2013, Stephane Eranian wrote: > >> On Thu, Nov 28, 2013 at 1:26 PM, Ingo Molnar wrote: >> > >> > * Vince Weaver wrote: >> > >> >> On Wed, 27 Nov 2013, Stephane Eranian wrote: >> >> >> >> > On Wed, Nov 27, 2013 at 7:35 PM,

Re: [PATCH v7 3/4] perf,x86: add Intel RAPL PMU support

2013-11-29 Thread Vince Weaver
On Thu, 28 Nov 2013, Stephane Eranian wrote: > On Thu, Nov 28, 2013 at 1:26 PM, Ingo Molnar wrote: > > > > * Vince Weaver wrote: > > > >> On Wed, 27 Nov 2013, Stephane Eranian wrote: > >> > >> > On Wed, Nov 27, 2013 at 7:35 PM, Vince Weaver wrote: > >> > >> > > So I notice PP1 (which is the

Re: [PATCH v7 3/4] perf,x86: add Intel RAPL PMU support

2013-11-29 Thread Vince Weaver
On Thu, 28 Nov 2013, Stephane Eranian wrote: On Thu, Nov 28, 2013 at 1:26 PM, Ingo Molnar mi...@kernel.org wrote: * Vince Weaver vi...@deater.net wrote: On Wed, 27 Nov 2013, Stephane Eranian wrote: On Wed, Nov 27, 2013 at 7:35 PM, Vince Weaver vi...@deater.net wrote: So I

Re: [PATCH v7 3/4] perf,x86: add Intel RAPL PMU support

2013-11-29 Thread Stephane Eranian
On Fri, Nov 29, 2013 at 8:16 PM, Vince Weaver vi...@deater.net wrote: On Thu, 28 Nov 2013, Stephane Eranian wrote: On Thu, Nov 28, 2013 at 1:26 PM, Ingo Molnar mi...@kernel.org wrote: * Vince Weaver vi...@deater.net wrote: On Wed, 27 Nov 2013, Stephane Eranian wrote: On Wed, Nov

Re: [PATCH v7 3/4] perf,x86: add Intel RAPL PMU support

2013-11-29 Thread Borislav Petkov
On Fri, Nov 29, 2013 at 09:09:46PM +0100, Stephane Eranian wrote: So in theory it would be harmless to export the values even if not supported. What is the worst failure mode? That somehow a recent CPU doesn't support the MSR and we get a GPF when trying to access it? Yes. I think

Re: [PATCH v7 3/4] perf,x86: add Intel RAPL PMU support

2013-11-29 Thread Stephane Eranian
Vince, Ok, I have added PP1 now and it works fine on my HSW desktop. What I want to know now is what is this map to on servers? And on clients, it is always mapped to the GFX. If so, then we can use a more specific name: power/energy-gfx/ I will send a patch soon. Thanks. On Fri, Nov 29, 2013

Re: [PATCH v7 3/4] perf,x86: add Intel RAPL PMU support

2013-11-28 Thread Stephane Eranian
On Thu, Nov 28, 2013 at 1:26 PM, Ingo Molnar wrote: > > * Vince Weaver wrote: > >> On Wed, 27 Nov 2013, Stephane Eranian wrote: >> >> > On Wed, Nov 27, 2013 at 7:35 PM, Vince Weaver wrote: >> >> > > So I notice PP1 (which is the GPU power on non-server chips) >> > > is not supported. >> > > >>

Re: [PATCH v7 3/4] perf,x86: add Intel RAPL PMU support

2013-11-28 Thread Ingo Molnar
* Vince Weaver wrote: > On Wed, 27 Nov 2013, Stephane Eranian wrote: > > > On Wed, Nov 27, 2013 at 7:35 PM, Vince Weaver wrote: > > > > So I notice PP1 (which is the GPU power on non-server chips) > > > is not supported. > > > > > > Is that just for simplicity? > > > > > Does it work on

Re: [PATCH v7 3/4] perf,x86: add Intel RAPL PMU support

2013-11-28 Thread Ingo Molnar
* Vince Weaver vi...@deater.net wrote: On Wed, 27 Nov 2013, Stephane Eranian wrote: On Wed, Nov 27, 2013 at 7:35 PM, Vince Weaver vi...@deater.net wrote: So I notice PP1 (which is the GPU power on non-server chips) is not supported. Is that just for simplicity? Does it

Re: [PATCH v7 3/4] perf,x86: add Intel RAPL PMU support

2013-11-28 Thread Stephane Eranian
On Thu, Nov 28, 2013 at 1:26 PM, Ingo Molnar mi...@kernel.org wrote: * Vince Weaver vi...@deater.net wrote: On Wed, 27 Nov 2013, Stephane Eranian wrote: On Wed, Nov 27, 2013 at 7:35 PM, Vince Weaver vi...@deater.net wrote: So I notice PP1 (which is the GPU power on non-server chips)

Re: [PATCH v7 3/4] perf,x86: add Intel RAPL PMU support

2013-11-27 Thread Vince Weaver
On Wed, 27 Nov 2013, Stephane Eranian wrote: > On Wed, Nov 27, 2013 at 7:35 PM, Vince Weaver wrote: > > So I notice PP1 (which is the GPU power on non-server chips) > > is not supported. > > > > Is that just for simplicity? > > > Does it work on specific models only? I bet so. How to detect

Re: [PATCH v7 3/4] perf,x86: add Intel RAPL PMU support

2013-11-27 Thread Stephane Eranian
On Wed, Nov 27, 2013 at 7:35 PM, Vince Weaver wrote: > On Tue, 12 Nov 2013, Stephane Eranian wrote: > >> This patch adds a new uncore PMU to expose the Intel >> RAPL energy consumption counters. Up to 3 counters, >> each counting a particular RAPL event are exposed. >> >> The RAPL counters are

Re: [PATCH v7 3/4] perf,x86: add Intel RAPL PMU support

2013-11-27 Thread Vince Weaver
On Tue, 12 Nov 2013, Stephane Eranian wrote: > This patch adds a new uncore PMU to expose the Intel > RAPL energy consumption counters. Up to 3 counters, > each counting a particular RAPL event are exposed. > > The RAPL counters are available on Intel SandyBridge, > IvyBridge, Haswell. The

Re: [PATCH v7 3/4] perf,x86: add Intel RAPL PMU support

2013-11-27 Thread Peter Zijlstra
On Tue, Nov 12, 2013 at 05:58:50PM +0100, Stephane Eranian wrote: > Sampling is not supported by the RAPL PMU. There is no > privilege level filtering either. > > Signed-off-by: Stephane Eranian > Signed-off-by: Maria Dimakopoulou So the merge window closed and we're starting to merge new bits

Re: [PATCH v7 3/4] perf,x86: add Intel RAPL PMU support

2013-11-27 Thread Peter Zijlstra
On Tue, Nov 12, 2013 at 05:58:50PM +0100, Stephane Eranian wrote: Sampling is not supported by the RAPL PMU. There is no privilege level filtering either. Signed-off-by: Stephane Eranian eran...@google.com Signed-off-by: Maria Dimakopoulou maria.n.dimakopou...@gmail.com So the merge window

Re: [PATCH v7 3/4] perf,x86: add Intel RAPL PMU support

2013-11-27 Thread Vince Weaver
On Tue, 12 Nov 2013, Stephane Eranian wrote: This patch adds a new uncore PMU to expose the Intel RAPL energy consumption counters. Up to 3 counters, each counting a particular RAPL event are exposed. The RAPL counters are available on Intel SandyBridge, IvyBridge, Haswell. The server skus

Re: [PATCH v7 3/4] perf,x86: add Intel RAPL PMU support

2013-11-27 Thread Stephane Eranian
On Wed, Nov 27, 2013 at 7:35 PM, Vince Weaver vi...@deater.net wrote: On Tue, 12 Nov 2013, Stephane Eranian wrote: This patch adds a new uncore PMU to expose the Intel RAPL energy consumption counters. Up to 3 counters, each counting a particular RAPL event are exposed. The RAPL counters

Re: [PATCH v7 3/4] perf,x86: add Intel RAPL PMU support

2013-11-27 Thread Vince Weaver
On Wed, 27 Nov 2013, Stephane Eranian wrote: On Wed, Nov 27, 2013 at 7:35 PM, Vince Weaver vi...@deater.net wrote: So I notice PP1 (which is the GPU power on non-server chips) is not supported. Is that just for simplicity? Does it work on specific models only? I bet so. How to detect

[PATCH v7 3/4] perf,x86: add Intel RAPL PMU support

2013-11-12 Thread Stephane Eranian
This patch adds a new uncore PMU to expose the Intel RAPL energy consumption counters. Up to 3 counters, each counting a particular RAPL event are exposed. The RAPL counters are available on Intel SandyBridge, IvyBridge, Haswell. The server skus add a 3rd counter. The following events are

[PATCH v7 3/4] perf,x86: add Intel RAPL PMU support

2013-11-12 Thread Stephane Eranian
This patch adds a new uncore PMU to expose the Intel RAPL energy consumption counters. Up to 3 counters, each counting a particular RAPL event are exposed. The RAPL counters are available on Intel SandyBridge, IvyBridge, Haswell. The server skus add a 3rd counter. The following events are