Re: [PATCH v7 3/5] usb: host: ohci-sm501: init genalloc for local memory

2019-06-25 Thread Christoph Hellwig
On Mon, Jun 24, 2019 at 02:59:16PM +0200, Fredrik Noring wrote: > Hi Christoph, > > > Can you send me the patch formally so that I can queue it up for the > > dma-mapping tree? > > That patch would be detrimental to local memory devices, as previously > discussed, so I would like to suggest a

Re: [PATCH v7 3/5] usb: host: ohci-sm501: init genalloc for local memory

2019-06-24 Thread Fredrik Noring
Hi Christoph, > Can you send me the patch formally so that I can queue it up for the > dma-mapping tree? That patch would be detrimental to local memory devices, as previously discussed, so I would like to suggest a much better approach, as shown below, where allocations are aligned as required

Re: [PATCH v7 3/5] usb: host: ohci-sm501: init genalloc for local memory

2019-06-24 Thread Christoph Hellwig
Can you send me the patch formally so that I can queue it up for the dma-mapping tree?

RE: [PATCH v7 3/5] usb: host: ohci-sm501: init genalloc for local memory

2019-06-18 Thread Laurentiu Tudor
Hello, > -Original Message- > From: Guenter Roeck On Behalf Of Guenter Roeck > Sent: Thursday, June 13, 2019 9:06 PM > > On 6/13/19 8:34 AM, Fredrik Noring wrote: > > Hi Guenter, > > > >> Thanks for the confirmation. Do you see the problem only with the > >> ohci-sm501 driver or also

Re: [PATCH v7 3/5] usb: host: ohci-sm501: init genalloc for local memory

2019-06-14 Thread Fredrik Noring
Hi Guenter, > You are right, the patch below fixes the problem. I did not get the warning > with order==5. Nevertheless, I also tested with order==8; that works as well. > > Thanks a lot for tracking this down! You are welcome, and thanks for your report! This patch series needs some redesign,

Re: [PATCH v7 3/5] usb: host: ohci-sm501: init genalloc for local memory

2019-06-13 Thread Guenter Roeck
On 6/13/19 8:34 AM, Fredrik Noring wrote: Hi Guenter, Thanks for the confirmation. Do you see the problem only with the ohci-sm501 driver or also with others ? All are likely affected, but it depends, because I believe the problem is that the USB subsystem runs out of memory. Please try the

Re: [PATCH v7 3/5] usb: host: ohci-sm501: init genalloc for local memory

2019-06-13 Thread Fredrik Noring
Hi Guenter, > Thanks for the confirmation. Do you see the problem only with the > ohci-sm501 driver or also with others ? All are likely affected, but it depends, because I believe the problem is that the USB subsystem runs out of memory. Please try the attached patch! The pool assumed 4096

Re: [PATCH v7 3/5] usb: host: ohci-sm501: init genalloc for local memory

2019-06-13 Thread Fredrik Noring
Hi Guenter, > I don't think I'll have time to do that anytime soon. Not that I know what > exactly to look for in the first place. I can confirm that there is a problem with mass storage devices and these local memory patches. Fredrik

Re: [PATCH v7 3/5] usb: host: ohci-sm501: init genalloc for local memory

2019-06-13 Thread Guenter Roeck
Hi Fredrik, On 6/13/19 6:40 AM, Fredrik Noring wrote: Hi Guenter, I don't think I'll have time to do that anytime soon. Not that I know what exactly to look for in the first place. I can confirm that there is a problem with mass storage devices and these local memory patches. Thanks for

Re: [PATCH v7 3/5] usb: host: ohci-sm501: init genalloc for local memory

2019-06-11 Thread Guenter Roeck
On Tue, Jun 11, 2019 at 07:26:54PM +0200, Fredrik Noring wrote: > Hi Guenter, > > > > This patch results in usb access failures when trying to boot from the > > > sm501-usb controller on sh4 with qemu. > > > > > > usb 1-2.1: reset full-speed USB device number 4 using sm501-usb > > > sd 1:0:0:0:

Re: [PATCH v7 3/5] usb: host: ohci-sm501: init genalloc for local memory

2019-06-11 Thread Fredrik Noring
Hi Guenter, > > This patch results in usb access failures when trying to boot from the > > sm501-usb controller on sh4 with qemu. > > > > usb 1-2.1: reset full-speed USB device number 4 using sm501-usb > > sd 1:0:0:0: [sda] tag#0 UNKNOWN(0x2003) Result: hostbyte=0x03 > > driverbyte=0x00 > > sd

Re: [PATCH v7 3/5] usb: host: ohci-sm501: init genalloc for local memory

2019-06-11 Thread Guenter Roeck
On Wed, Jun 05, 2019 at 02:46:22PM -0700, Guenter Roeck wrote: > On Wed, May 29, 2019 at 01:28:41PM +0300, laurentiu.tu...@nxp.com wrote: > > From: Laurentiu Tudor > > > > In preparation for dropping the existing "coherent" dma mem declaration > > APIs, replace the current

Re: [PATCH v7 3/5] usb: host: ohci-sm501: init genalloc for local memory

2019-06-05 Thread Guenter Roeck
On Wed, May 29, 2019 at 01:28:41PM +0300, laurentiu.tu...@nxp.com wrote: > From: Laurentiu Tudor > > In preparation for dropping the existing "coherent" dma mem declaration > APIs, replace the current dma_declare_coherent_memory() based mechanism > with the creation of a genalloc pool that will

[PATCH v7 3/5] usb: host: ohci-sm501: init genalloc for local memory

2019-05-29 Thread laurentiu . tudor
From: Laurentiu Tudor In preparation for dropping the existing "coherent" dma mem declaration APIs, replace the current dma_declare_coherent_memory() based mechanism with the creation of a genalloc pool that will be used in the OHCI subsystem as replacement for the DMA APIs. For context, see