Re: [PATCH v7 6/7] OPP: Update the bandwidth on OPP frequency changes

2020-05-04 Thread Viresh Kumar
On 04-05-20, 14:01, Saravana Kannan wrote: > Fair enough. But don't "voltage corner" based devices NEED to use OPP > framework to set their frequencies? No. Anyone can call dev_pm_genpd_set_performance_state(). -- viresh

Re: [PATCH v7 6/7] OPP: Update the bandwidth on OPP frequency changes

2020-05-04 Thread Saravana Kannan
On Sun, May 3, 2020 at 10:00 PM Viresh Kumar wrote: > > On 30-04-20, 09:32, Saravana Kannan wrote: > > You are missing the point. This is not about aggregation. This is > > about OPP voting for bandwidth on a path when the vote can/should be > > 0. > > > > I'll give another example. Say one of the

Re: [PATCH v7 6/7] OPP: Update the bandwidth on OPP frequency changes

2020-05-04 Thread Sibi Sankar
On 2020-04-24 21:24, Georgi Djakov wrote: If the OPP bandwidth values are populated, we want to switch also the interconnect bandwidth in addition to frequency and voltage. https://patchwork.kernel.org/patch/11527571/ Scaling from set_rate or using ^^ to set bw levels, I'm fine with both. Re

Re: [PATCH v7 6/7] OPP: Update the bandwidth on OPP frequency changes

2020-05-03 Thread Viresh Kumar
On 30-04-20, 09:32, Saravana Kannan wrote: > You are missing the point. This is not about aggregation. This is > about OPP voting for bandwidth on a path when the vote can/should be > 0. > > I'll give another example. Say one of the interconnect paths needs to > be voted only when a particular use

Re: [PATCH v7 6/7] OPP: Update the bandwidth on OPP frequency changes

2020-04-30 Thread Saravana Kannan
On Thu, Apr 30, 2020 at 12:54 AM Viresh Kumar wrote: > > On 30-04-20, 00:35, Saravana Kannan wrote: > > On Wed, Apr 29, 2020 at 11:09 PM Viresh Kumar > > wrote: > > > > > > On 24-04-20, 14:18, Saravana Kannan wrote: > > > > My only comment is -- can we drop this patch please? I'd like to use > >

Re: [PATCH v7 6/7] OPP: Update the bandwidth on OPP frequency changes

2020-04-30 Thread Viresh Kumar
On 30-04-20, 00:35, Saravana Kannan wrote: > On Wed, Apr 29, 2020 at 11:09 PM Viresh Kumar wrote: > > > > On 24-04-20, 14:18, Saravana Kannan wrote: > > > My only comment is -- can we drop this patch please? I'd like to use > > > devfreq governors for voting on bandwidth and this will effectively

Re: [PATCH v7 6/7] OPP: Update the bandwidth on OPP frequency changes

2020-04-30 Thread Saravana Kannan
On Wed, Apr 29, 2020 at 11:09 PM Viresh Kumar wrote: > > On 24-04-20, 14:18, Saravana Kannan wrote: > > My only comment is -- can we drop this patch please? I'd like to use > > devfreq governors for voting on bandwidth and this will effectively > > override whatever bandwidth decisions are made by

Re: [PATCH v7 6/7] OPP: Update the bandwidth on OPP frequency changes

2020-04-29 Thread Viresh Kumar
On 24-04-20, 14:18, Saravana Kannan wrote: > My only comment is -- can we drop this patch please? I'd like to use > devfreq governors for voting on bandwidth and this will effectively > override whatever bandwidth decisions are made by the devfreq > governor. And why would that be better ? FWIW, t