Re: [PATCH v8 04/14] media: platform: Change the fixed device node number to unfixed value

2020-06-04 Thread Xia Jiang
On Thu, 2020-05-21 at 13:59 +, Tomasz Figa wrote: > Hi Xia, > > On Fri, Apr 03, 2020 at 05:40:23PM +0800, Xia Jiang wrote: > > Change device node number from 3 to -1 because that the driver will > > also support jpeg encoder. > > > > Thanks for the patch. The change is correct, but I think t

Re: [PATCH v8 04/14] media: platform: Change the fixed device node number to unfixed value

2020-05-21 Thread Tomasz Figa
Hi Xia, On Fri, Apr 03, 2020 at 05:40:23PM +0800, Xia Jiang wrote: > Change device node number from 3 to -1 because that the driver will > also support jpeg encoder. > Thanks for the patch. The change is correct, but I think the commit message doesn't really explain the real reason for it. Perha

Re: [PATCH v8 04/14] media: platform: Change the fixed device node number to unfixed value

2020-05-11 Thread Hans Verkuil
On 03/04/2020 11:40, Xia Jiang wrote: > Change device node number from 3 to -1 because that the driver will > also support jpeg encoder. > > Signed-off-by: Xia Jiang > --- > drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/