Re: [PATCH v8 06/10] iommu/vt-d: datatypes and functions used for kdump

2015-01-14 Thread Baoquan He
On 01/15/15 at 01:45pm, Li, ZhenHua wrote: > Hi Baoquan, > Thank you very much for your review. But according to the latest > discussion, the page tables will not be copied from old kernel. We keep > using the old page tables before driver is loaded. So there are many > changes in next version;

Re: [PATCH v8 06/10] iommu/vt-d: datatypes and functions used for kdump

2015-01-14 Thread Li, ZhenHua
Hi Baoquan, Thank you very much for your review. But according to the latest discussion, the page tables will not be copied from old kernel. We keep using the old page tables before driver is loaded. So there are many changes in next version; See my comments. On 01/15/2015 11:28 AM, Baoquan He

Re: [PATCH v8 06/10] iommu/vt-d: datatypes and functions used for kdump

2015-01-14 Thread Baoquan He
On 01/12/15 at 03:06pm, Li, Zhen-Hua wrote: > +/* > + * Interface to the "copy translation tables" set of functions > + * from mainline code. > + */ > +static int intel_iommu_load_translation_tables(struct dmar_drhd_unit *drhd, > + int g_num_of_iommus) The argument g_num_of_iommus is

Re: [PATCH v8 06/10] iommu/vt-d: datatypes and functions used for kdump

2015-01-14 Thread Li, ZhenHua
Hi Baoquan, Thank you very much for your review. But according to the latest discussion, the page tables will not be copied from old kernel. We keep using the old page tables before driver is loaded. So there are many changes in next version; See my comments. On 01/15/2015 11:28 AM, Baoquan He

Re: [PATCH v8 06/10] iommu/vt-d: datatypes and functions used for kdump

2015-01-14 Thread Baoquan He
On 01/12/15 at 03:06pm, Li, Zhen-Hua wrote: +/* + * Interface to the copy translation tables set of functions + * from mainline code. + */ +static int intel_iommu_load_translation_tables(struct dmar_drhd_unit *drhd, + int g_num_of_iommus) The argument g_num_of_iommus is the same

Re: [PATCH v8 06/10] iommu/vt-d: datatypes and functions used for kdump

2015-01-14 Thread Baoquan He
On 01/15/15 at 01:45pm, Li, ZhenHua wrote: Hi Baoquan, Thank you very much for your review. But according to the latest discussion, the page tables will not be copied from old kernel. We keep using the old page tables before driver is loaded. So there are many changes in next version; Oh,

[PATCH v8 06/10] iommu/vt-d: datatypes and functions used for kdump

2015-01-11 Thread Li, Zhen-Hua
Populate it with support functions to copy iommu translation tables from from the panicked kernel into the kdump kernel in the event of a crash. Functions: malloc new context table and copy old context table to the new one. malloc new page table and copy old page table to the new one.

[PATCH v8 06/10] iommu/vt-d: datatypes and functions used for kdump

2015-01-11 Thread Li, Zhen-Hua
Populate it with support functions to copy iommu translation tables from from the panicked kernel into the kdump kernel in the event of a crash. Functions: malloc new context table and copy old context table to the new one. malloc new page table and copy old page table to the new one.