Re: [PATCH v8 10/17] phy: Add driver for rockchip Display Port PHY

2015-11-12 Thread Heiko Stuebner
Hi Yakir, Am Donnerstag, 12. November 2015, 10:36:51 schrieb Yakir Yang: > On 11/12/2015 07:23 AM, Heiko Stuebner wrote: > > Am Mittwoch, 28. Oktober 2015, 16:30:33 schrieb Yakir Yang: > >> Add phy driver for the Rockchip DisplayPort PHY module. This > >> is required to get DisplayPort working in

Re: [PATCH v8 10/17] phy: Add driver for rockchip Display Port PHY

2015-11-11 Thread Heiko Stuebner
Hi Yakir, Am Mittwoch, 28. Oktober 2015, 16:30:33 schrieb Yakir Yang: > Add phy driver for the Rockchip DisplayPort PHY module. This > is required to get DisplayPort working in Rockchip SoCs. > > Reviewed-by: Heiko Stuebner > Signed-off-by: Yakir Yang a general thing I have been pondering, we

Re: [PATCH v8 10/17] phy: Add driver for rockchip Display Port PHY

2015-10-28 Thread Yakir Yang
Hi Heiko, On 10/29/2015 04:36 AM, Heiko Stuebner wrote: Hi Yakir, Am Mittwoch, 28. Oktober 2015, 16:30:33 schrieb Yakir Yang: +static int rockchip_dp_phy_probe(struct platform_device *pdev) +{ + struct device *dev = &pdev->dev; + struct device_node *np = dev->of_node; + struc

Re: [PATCH v8 10/17] phy: Add driver for rockchip Display Port PHY

2015-10-28 Thread Heiko Stuebner
Hi Yakir, Am Mittwoch, 28. Oktober 2015, 16:30:33 schrieb Yakir Yang: > +static int rockchip_dp_phy_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct device_node *np = dev->of_node; > + struct phy_provider *phy_provider; > + struct rockchip_dp

[PATCH v8 10/17] phy: Add driver for rockchip Display Port PHY

2015-10-28 Thread Yakir Yang
Add phy driver for the Rockchip DisplayPort PHY module. This is required to get DisplayPort working in Rockchip SoCs. Reviewed-by: Heiko Stuebner Signed-off-by: Yakir Yang --- Changes in v8: - Fix the mixed spacers on macro definitions. (Heiko) - Remove the unnecessary empty line after clk_prepa