Re: [PATCH v8 2/3] mfd: add Gateworks System Controller core driver

2020-04-30 Thread Lee Jones
On Wed, 29 Apr 2020, Tim Harvey wrote: > On Tue, Apr 28, 2020 at 11:33 PM Lee Jones wrote: > > > > On Tue, 28 Apr 2020, Tim Harvey wrote: > > > > > On Tue, Apr 28, 2020 at 2:44 AM Lee Jones wrote: > > > > > > > > > > > > + > > > > > +static int gsc_probe(struct i2c_client *client) > > > > > +{

Re: [PATCH v8 2/3] mfd: add Gateworks System Controller core driver

2020-04-29 Thread Tim Harvey
On Tue, Apr 28, 2020 at 11:33 PM Lee Jones wrote: > > On Tue, 28 Apr 2020, Tim Harvey wrote: > > > On Tue, Apr 28, 2020 at 2:44 AM Lee Jones wrote: > > > > > > > > > + > > > > +static int gsc_probe(struct i2c_client *client) > > > > +{ > > > > + struct device *dev = >dev; > > > > +

Re: [PATCH v8 2/3] mfd: add Gateworks System Controller core driver

2020-04-29 Thread Lee Jones
On Tue, 28 Apr 2020, Tim Harvey wrote: > On Tue, Apr 28, 2020 at 2:44 AM Lee Jones wrote: > > > > > > + > > > +static int gsc_probe(struct i2c_client *client) > > > +{ > > > + struct device *dev = >dev; > > > + struct gsc_dev *gsc; > > > + int ret; > > > + unsigned int reg; > >

Re: [PATCH v8 2/3] mfd: add Gateworks System Controller core driver

2020-04-28 Thread Tim Harvey
On Tue, Apr 28, 2020 at 2:44 AM Lee Jones wrote: > > > + > > +static int gsc_probe(struct i2c_client *client) > > +{ > > + struct device *dev = >dev; > > + struct gsc_dev *gsc; > > + int ret; > > + unsigned int reg; > > + > > + gsc = devm_kzalloc(dev, sizeof(*gsc),

Re: [PATCH v8 2/3] mfd: add Gateworks System Controller core driver

2020-04-28 Thread Lee Jones
On Fri, 27 Mar 2020, Tim Harvey wrote: > The Gateworks System Controller (GSC) is an I2C slave controller > implemented with an MSP430 micro-controller whose firmware embeds the > following features: > - I/O expander (16 GPIO's) using PCA955x protocol > - Real Time Clock using DS1672 protocol >