Re: [PATCH v8 3/9] perf/amd/iommu: Misc fix up perf_iommu_read

2017-02-06 Thread Suravee Suthikulpanit
Peter, On 1/23/17 19:33, Peter Zijlstra wrote: On Mon, Jan 16, 2017 at 01:23:30AM -0600, Suravee Suthikulpanit wrote: static void perf_iommu_read(struct perf_event *event) { - u64 count = 0ULL; - u64 prev_raw_count = 0ULL; - u64 delta = 0ULL; + u64 count, prev; +

Re: [PATCH v8 3/9] perf/amd/iommu: Misc fix up perf_iommu_read

2017-01-23 Thread Peter Zijlstra
On Mon, Jan 16, 2017 at 01:23:30AM -0600, Suravee Suthikulpanit wrote: > static void perf_iommu_read(struct perf_event *event) > { > - u64 count = 0ULL; > - u64 prev_raw_count = 0ULL; > - u64 delta = 0ULL; > + u64 count, prev; > + s64 delta; I did send that email where I told

Re: [PATCH v8 3/9] perf/amd/iommu: Misc fix up perf_iommu_read

2017-01-19 Thread Borislav Petkov
> Subject: Re: [PATCH v8 3/9] perf/amd/iommu: Misc fix up perf_iommu_read Please be a bit more thorough when writing your commit messages. What is a "misc fix up"? Perhaps it is ok for a quick'n'dirty local patch but not when it is for upstream. Also, function names

[PATCH v8 3/9] perf/amd/iommu: Misc fix up perf_iommu_read

2017-01-15 Thread Suravee Suthikulpanit
* Fix overflow handling since u64 delta would lose the MSB sign bit. * Remove unnecessary local64_cmpxchg(). * Coding style and make use of GENMASK_ULL macro. Cc: Peter Zijlstra Cc: Borislav Petkov Signed-off-by: Suravee Suthikulpanit --- arch/x86/events/amd/iommu.c | 23 --