Re: [PATCH v8 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-07-09 Thread Iyappan Subramanian
On Wed, Jun 25, 2014 at 4:04 PM, Russell King - ARM Linux wrote: > On Tue, Jun 24, 2014 at 10:29:48PM -0600, Dann Frazier wrote: >> On Fri, Jun 20, 2014 at 5:18 PM, Iyappan Subramanian >> wrote: >> > + ring->desc_addr = dma_zalloc_coherent(dev, size, >dma, >> > +

Re: [PATCH v8 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-07-09 Thread Iyappan Subramanian
On Tue, Jun 24, 2014 at 10:34 PM, David Miller wrote: > From: Iyappan Subramanian > Date: Fri, 20 Jun 2014 16:18:16 -0700 > >> This patch adds network driver for APM X-Gene SoC ethernet. >> >> Signed-off-by: Iyappan Subramanian >> Signed-off-by: Ravi Patel >> Signed-off-by: Keyur Chudgar > >

Re: [PATCH v8 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-07-09 Thread Iyappan Subramanian
On Tue, Jun 24, 2014 at 10:34 PM, David Miller da...@davemloft.net wrote: From: Iyappan Subramanian isubraman...@apm.com Date: Fri, 20 Jun 2014 16:18:16 -0700 This patch adds network driver for APM X-Gene SoC ethernet. Signed-off-by: Iyappan Subramanian isubraman...@apm.com Signed-off-by:

Re: [PATCH v8 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-07-09 Thread Iyappan Subramanian
On Wed, Jun 25, 2014 at 4:04 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Tue, Jun 24, 2014 at 10:29:48PM -0600, Dann Frazier wrote: On Fri, Jun 20, 2014 at 5:18 PM, Iyappan Subramanian isubraman...@apm.com wrote: + ring-desc_addr = dma_zalloc_coherent(dev, size,

Re: [PATCH v8 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-06-25 Thread Russell King - ARM Linux
On Tue, Jun 24, 2014 at 10:29:48PM -0600, Dann Frazier wrote: > On Fri, Jun 20, 2014 at 5:18 PM, Iyappan Subramanian > wrote: > > + ring->desc_addr = dma_zalloc_coherent(dev, size, >dma, > > + GFP_KERNEL); > > Iyappan, > When testing this driver

Re: [PATCH v8 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-06-25 Thread Mark Salter
On Tue, 2014-06-24 at 22:29 -0600, Dann Frazier wrote: > On Fri, Jun 20, 2014 at 5:18 PM, Iyappan Subramanian > > + ring->desc_addr = dma_zalloc_coherent(dev, size, >dma, > > + GFP_KERNEL); > > Iyappan, > When testing this driver on a 3.16-rc2

Re: [PATCH v8 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-06-25 Thread Mark Salter
On Tue, 2014-06-24 at 22:29 -0600, Dann Frazier wrote: On Fri, Jun 20, 2014 at 5:18 PM, Iyappan Subramanian + ring-desc_addr = dma_zalloc_coherent(dev, size, ring-dma, + GFP_KERNEL); Iyappan, When testing this driver on a 3.16-rc2 base,

Re: [PATCH v8 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-06-25 Thread Russell King - ARM Linux
On Tue, Jun 24, 2014 at 10:29:48PM -0600, Dann Frazier wrote: On Fri, Jun 20, 2014 at 5:18 PM, Iyappan Subramanian isubraman...@apm.com wrote: + ring-desc_addr = dma_zalloc_coherent(dev, size, ring-dma, + GFP_KERNEL); Iyappan, When

Re: [PATCH v8 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-06-24 Thread David Miller
From: Iyappan Subramanian Date: Fri, 20 Jun 2014 16:18:16 -0700 > This patch adds network driver for APM X-Gene SoC ethernet. > > Signed-off-by: Iyappan Subramanian > Signed-off-by: Ravi Patel > Signed-off-by: Keyur Chudgar I really don't like how you handle the hardware descriptors in this

Re: [PATCH v8 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-06-24 Thread Dann Frazier
On Fri, Jun 20, 2014 at 5:18 PM, Iyappan Subramanian wrote: > This patch adds network driver for APM X-Gene SoC ethernet. > > Signed-off-by: Iyappan Subramanian > Signed-off-by: Ravi Patel > Signed-off-by: Keyur Chudgar > --- > drivers/net/ethernet/Kconfig | 1 + >

Re: [PATCH v8 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-06-24 Thread Dann Frazier
On Fri, Jun 20, 2014 at 5:18 PM, Iyappan Subramanian isubraman...@apm.com wrote: This patch adds network driver for APM X-Gene SoC ethernet. Signed-off-by: Iyappan Subramanian isubraman...@apm.com Signed-off-by: Ravi Patel rapa...@apm.com Signed-off-by: Keyur Chudgar kchud...@apm.com ---

Re: [PATCH v8 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-06-24 Thread David Miller
From: Iyappan Subramanian isubraman...@apm.com Date: Fri, 20 Jun 2014 16:18:16 -0700 This patch adds network driver for APM X-Gene SoC ethernet. Signed-off-by: Iyappan Subramanian isubraman...@apm.com Signed-off-by: Ravi Patel rapa...@apm.com Signed-off-by: Keyur Chudgar kchud...@apm.com I