Re: [PATCH v8 4/8] IMA: add policy rule to measure critical data

2020-12-12 Thread Tushar Sugandhi
+ case CRITICAL_DATA: + if (!rule->data_source) + return true; + + opt_list = rule->data_source; + break; I guess this case should unconditionally return true in this patch and then the include this additional logic in the

Re: [PATCH v8 4/8] IMA: add policy rule to measure critical data

2020-12-12 Thread Tyler Hicks
On 2020-12-11 17:17:22, Tushar Sugandhi wrote: > > > On 2020-12-11 4:25 p.m., Tyler Hicks wrote: > > On 2020-12-11 15:58:03, Tushar Sugandhi wrote: > > > A new IMA policy rule is needed for the IMA hook > > > ima_measure_critical_data() and the corresponding func CRITICAL_DATA for > > >

Re: [PATCH v8 4/8] IMA: add policy rule to measure critical data

2020-12-11 Thread Tushar Sugandhi
On 2020-12-11 4:25 p.m., Tyler Hicks wrote: On 2020-12-11 15:58:03, Tushar Sugandhi wrote: A new IMA policy rule is needed for the IMA hook ima_measure_critical_data() and the corresponding func CRITICAL_DATA for measuring the input buffer. The policy rule should ensure the buffer would get

Re: [PATCH v8 4/8] IMA: add policy rule to measure critical data

2020-12-11 Thread Tyler Hicks
On 2020-12-11 15:58:03, Tushar Sugandhi wrote: > A new IMA policy rule is needed for the IMA hook > ima_measure_critical_data() and the corresponding func CRITICAL_DATA for > measuring the input buffer. The policy rule should ensure the buffer > would get measured only when the policy rule allows

[PATCH v8 4/8] IMA: add policy rule to measure critical data

2020-12-11 Thread Tushar Sugandhi
A new IMA policy rule is needed for the IMA hook ima_measure_critical_data() and the corresponding func CRITICAL_DATA for measuring the input buffer. The policy rule should ensure the buffer would get measured only when the policy rule allows the action. The policy rule should also support the