Re: [PATCH v8 6/6] usb: musb: Add support for MediaTek musb controller

Hi, On Thu, 2019-10-17 at 09:34 -0700, Tony Lindgren wrote: > Hi, > > Just few comments for future changes that might help below. > > * min@mediatek.com [191017 09:42]: > > --- /dev/null > > +++ b/drivers/usb/musb/mediatek.c > > +static int musb_usb_role_sx_set(struct device *dev, enum usb_r

Re: [PATCH v8 6/6] usb: musb: Add support for MediaTek musb controller

Hi, Just few comments for future changes that might help below. * min@mediatek.com [191017 09:42]: > --- /dev/null > +++ b/drivers/usb/musb/mediatek.c > +static int musb_usb_role_sx_set(struct device *dev, enum usb_role role) > +{ > + struct mtk_glue *glue = dev_get_drvdata(dev); > +

[PATCH v8 6/6] usb: musb: Add support for MediaTek musb controller

From: Min Guo This adds support for MediaTek musb controller in host, peripheral and otg mode. There are some quirk of MediaTek musb controller, such as: -W1C interrupt status registers -Private data toggle registers -No dedicated DMA interrupt line Signed-off-by: Min Guo Signed-off-by: Yong