Re: [PATCH v9 02/15] sched/cpufreq: Prepare schedutil for Energy Aware Scheduling

2018-11-20 Thread Quentin Perret
On Tuesday 20 Nov 2018 at 16:25:14 (+0100), Peter Zijlstra wrote: > On Tue, Nov 20, 2018 at 10:16:02AM +0530, Viresh Kumar wrote: > > On 19-11-18, 14:18, Quentin Perret wrote: > > > @@ -223,20 +222,33 @@ static unsigned long sugov_get_util(struct > > > sugov_cpu *sg_cpu) > > > > > - if ((util +

Re: [PATCH v9 02/15] sched/cpufreq: Prepare schedutil for Energy Aware Scheduling

2018-11-20 Thread Quentin Perret
On Tuesday 20 Nov 2018 at 16:25:14 (+0100), Peter Zijlstra wrote: > On Tue, Nov 20, 2018 at 10:16:02AM +0530, Viresh Kumar wrote: > > On 19-11-18, 14:18, Quentin Perret wrote: > > > @@ -223,20 +222,33 @@ static unsigned long sugov_get_util(struct > > > sugov_cpu *sg_cpu) > > > > > - if ((util +

Re: [PATCH v9 02/15] sched/cpufreq: Prepare schedutil for Energy Aware Scheduling

2018-11-20 Thread Peter Zijlstra
On Tue, Nov 20, 2018 at 10:16:02AM +0530, Viresh Kumar wrote: > On 19-11-18, 14:18, Quentin Perret wrote: > > @@ -223,20 +222,33 @@ static unsigned long sugov_get_util(struct sugov_cpu > > *sg_cpu) > > > - if ((util + cpu_util_dl(rq)) >= max) > > - return max; > > + if (type ==

Re: [PATCH v9 02/15] sched/cpufreq: Prepare schedutil for Energy Aware Scheduling

2018-11-20 Thread Peter Zijlstra
On Tue, Nov 20, 2018 at 10:16:02AM +0530, Viresh Kumar wrote: > On 19-11-18, 14:18, Quentin Perret wrote: > > @@ -223,20 +222,33 @@ static unsigned long sugov_get_util(struct sugov_cpu > > *sg_cpu) > > > - if ((util + cpu_util_dl(rq)) >= max) > > - return max; > > + if (type ==

Re: [PATCH v9 02/15] sched/cpufreq: Prepare schedutil for Energy Aware Scheduling

2018-11-19 Thread Viresh Kumar
On 19-11-18, 14:18, Quentin Perret wrote: > @@ -223,20 +222,33 @@ static unsigned long sugov_get_util(struct sugov_cpu > *sg_cpu) > - if ((util + cpu_util_dl(rq)) >= max) > - return max; > + if (type == FREQUENCY_UTIL) { > + /* > + * For frequency

Re: [PATCH v9 02/15] sched/cpufreq: Prepare schedutil for Energy Aware Scheduling

2018-11-19 Thread Viresh Kumar
On 19-11-18, 14:18, Quentin Perret wrote: > @@ -223,20 +222,33 @@ static unsigned long sugov_get_util(struct sugov_cpu > *sg_cpu) > - if ((util + cpu_util_dl(rq)) >= max) > - return max; > + if (type == FREQUENCY_UTIL) { > + /* > + * For frequency

[PATCH v9 02/15] sched/cpufreq: Prepare schedutil for Energy Aware Scheduling

2018-11-19 Thread Quentin Perret
Schedutil requests frequency by aggregating utilization signals from the scheduler (CFS, RT, DL, IRQ) and applying a 25% margin on top of them. Since Energy Aware Scheduling (EAS) needs to be able to predict the frequency requests, it needs to forecast the decisions made by the governor. In order

[PATCH v9 02/15] sched/cpufreq: Prepare schedutil for Energy Aware Scheduling

2018-11-19 Thread Quentin Perret
Schedutil requests frequency by aggregating utilization signals from the scheduler (CFS, RT, DL, IRQ) and applying a 25% margin on top of them. Since Energy Aware Scheduling (EAS) needs to be able to predict the frequency requests, it needs to forecast the decisions made by the governor. In order