Re: [PATCH v9 08/20] gpiolib: cdev: support GPIO_V2_GET_LINEINFO_IOCTL and GPIO_V2_GET_LINEINFO_WATCH_IOCTL

2020-09-25 Thread Andy Shevchenko
On Fri, Sep 25, 2020 at 2:56 PM Kent Gibson wrote: > > On Fri, Sep 25, 2020 at 01:12:14PM +0300, Andy Shevchenko wrote: > > On Thu, Sep 24, 2020 at 12:48 PM Kent Gibson wrote: > > > On Thu, Sep 24, 2020 at 11:39:03AM +0300, Andy Shevchenko wrote: > > > > On Thu, Sep 24, 2020 at 5:39 AM Kent

Re: [PATCH v9 08/20] gpiolib: cdev: support GPIO_V2_GET_LINEINFO_IOCTL and GPIO_V2_GET_LINEINFO_WATCH_IOCTL

2020-09-25 Thread Kent Gibson
On Fri, Sep 25, 2020 at 01:12:14PM +0300, Andy Shevchenko wrote: > On Thu, Sep 24, 2020 at 12:48 PM Kent Gibson wrote: > > On Thu, Sep 24, 2020 at 11:39:03AM +0300, Andy Shevchenko wrote: > > > On Thu, Sep 24, 2020 at 5:39 AM Kent Gibson wrote: > > > > On Wed, Sep 23, 2020 at 06:41:45PM +0300,

Re: [PATCH v9 08/20] gpiolib: cdev: support GPIO_V2_GET_LINEINFO_IOCTL and GPIO_V2_GET_LINEINFO_WATCH_IOCTL

2020-09-25 Thread Andy Shevchenko
On Thu, Sep 24, 2020 at 12:48 PM Kent Gibson wrote: > On Thu, Sep 24, 2020 at 11:39:03AM +0300, Andy Shevchenko wrote: > > On Thu, Sep 24, 2020 at 5:39 AM Kent Gibson wrote: > > > On Wed, Sep 23, 2020 at 06:41:45PM +0300, Andy Shevchenko wrote: > > > > On Tue, Sep 22, 2020 at 5:35 AM Kent Gibson

Re: [PATCH v9 08/20] gpiolib: cdev: support GPIO_V2_GET_LINEINFO_IOCTL and GPIO_V2_GET_LINEINFO_WATCH_IOCTL

2020-09-24 Thread Kent Gibson
On Wed, Sep 23, 2020 at 06:41:45PM +0300, Andy Shevchenko wrote: > On Tue, Sep 22, 2020 at 5:35 AM Kent Gibson wrote: > > > > Add support for GPIO_V2_GET_LINEINFO_IOCTL and > > GPIO_V2_GET_LINEINFO_WATCH_IOCTL. > > > > +#ifdef CONFIG_GPIO_CDEV_V1 > > +static int lineinfo_ensure_abi_version(struct

Re: [PATCH v9 08/20] gpiolib: cdev: support GPIO_V2_GET_LINEINFO_IOCTL and GPIO_V2_GET_LINEINFO_WATCH_IOCTL

2020-09-24 Thread Kent Gibson
On Thu, Sep 24, 2020 at 11:39:03AM +0300, Andy Shevchenko wrote: > On Thu, Sep 24, 2020 at 5:39 AM Kent Gibson wrote: > > On Wed, Sep 23, 2020 at 06:41:45PM +0300, Andy Shevchenko wrote: > > > On Tue, Sep 22, 2020 at 5:35 AM Kent Gibson wrote: > > ... > [snip] > > > > > +static int

Re: [PATCH v9 08/20] gpiolib: cdev: support GPIO_V2_GET_LINEINFO_IOCTL and GPIO_V2_GET_LINEINFO_WATCH_IOCTL

2020-09-24 Thread Andy Shevchenko
On Thu, Sep 24, 2020 at 5:39 AM Kent Gibson wrote: > On Wed, Sep 23, 2020 at 06:41:45PM +0300, Andy Shevchenko wrote: > > On Tue, Sep 22, 2020 at 5:35 AM Kent Gibson wrote: ... > > > + memcpy(info_v1->consumer, info_v2->consumer, > > > + sizeof(info_v1->consumer)); > > > >

Re: [PATCH v9 08/20] gpiolib: cdev: support GPIO_V2_GET_LINEINFO_IOCTL and GPIO_V2_GET_LINEINFO_WATCH_IOCTL

2020-09-23 Thread Kent Gibson
On Wed, Sep 23, 2020 at 06:41:45PM +0300, Andy Shevchenko wrote: > On Tue, Sep 22, 2020 at 5:35 AM Kent Gibson wrote: > > > > Add support for GPIO_V2_GET_LINEINFO_IOCTL and > > GPIO_V2_GET_LINEINFO_WATCH_IOCTL. > > [snip] > > > > +static void gpio_v2_line_info_to_v1(struct gpio_v2_line_info

Re: [PATCH v9 08/20] gpiolib: cdev: support GPIO_V2_GET_LINEINFO_IOCTL and GPIO_V2_GET_LINEINFO_WATCH_IOCTL

2020-09-23 Thread Andy Shevchenko
On Tue, Sep 22, 2020 at 5:35 AM Kent Gibson wrote: > > Add support for GPIO_V2_GET_LINEINFO_IOCTL and > GPIO_V2_GET_LINEINFO_WATCH_IOCTL. > > The core of this change is the event kfifo switching to contain > struct gpioline_info_changed_v2, instead of v1 as v2 is richer. > > The two uAPI versions

[PATCH v9 08/20] gpiolib: cdev: support GPIO_V2_GET_LINEINFO_IOCTL and GPIO_V2_GET_LINEINFO_WATCH_IOCTL

2020-09-21 Thread Kent Gibson
Add support for GPIO_V2_GET_LINEINFO_IOCTL and GPIO_V2_GET_LINEINFO_WATCH_IOCTL. The core of this change is the event kfifo switching to contain struct gpioline_info_changed_v2, instead of v1 as v2 is richer. The two uAPI versions are mostly independent - other than where they both provide line