Re: [PATCH v9 2/2] regulator: add QCOM RPMh regulator driver

2018-08-10 Thread Doug Anderson
Hi, On Fri, Aug 10, 2018 at 9:29 AM, Mark Brown wrote: > On Fri, Jul 13, 2018 at 06:50:59PM -0700, David Collins wrote: > >> + switch (rpmh_mode) { > >> + default: >> + mode = REGULATOR_MODE_INVALID; >> + } > > I'm not sure why the break statements are being omitted in

Re: [PATCH v9 2/2] regulator: add QCOM RPMh regulator driver

2018-08-10 Thread Doug Anderson
Hi, On Fri, Aug 10, 2018 at 9:29 AM, Mark Brown wrote: > On Fri, Jul 13, 2018 at 06:50:59PM -0700, David Collins wrote: > >> + switch (rpmh_mode) { > >> + default: >> + mode = REGULATOR_MODE_INVALID; >> + } > > I'm not sure why the break statements are being omitted in

Re: [PATCH v9 2/2] regulator: add QCOM RPMh regulator driver

2018-08-10 Thread Mark Brown
On Fri, Jul 13, 2018 at 06:50:59PM -0700, David Collins wrote: > + switch (rpmh_mode) { > + default: > + mode = REGULATOR_MODE_INVALID; > + } I'm not sure why the break statements are being omitted in default cases, but I do find myself stopping and trying to figure it

Re: [PATCH v9 2/2] regulator: add QCOM RPMh regulator driver

2018-08-10 Thread Mark Brown
On Fri, Jul 13, 2018 at 06:50:59PM -0700, David Collins wrote: > + switch (rpmh_mode) { > + default: > + mode = REGULATOR_MODE_INVALID; > + } I'm not sure why the break statements are being omitted in default cases, but I do find myself stopping and trying to figure it

[PATCH v9 2/2] regulator: add QCOM RPMh regulator driver

2018-07-13 Thread David Collins
Add the QCOM RPMh regulator driver to manage PMIC regulators which are controlled via RPMh on some Qualcomm Technologies, Inc. SoCs. RPMh is a hardware block which contains several accelerators which are used to manage various hardware resources that are shared between the processors of the SoC.

[PATCH v9 2/2] regulator: add QCOM RPMh regulator driver

2018-07-13 Thread David Collins
Add the QCOM RPMh regulator driver to manage PMIC regulators which are controlled via RPMh on some Qualcomm Technologies, Inc. SoCs. RPMh is a hardware block which contains several accelerators which are used to manage various hardware resources that are shared between the processors of the SoC.