Re: [PATCH v9 3/3] remoteproc: zynqmp: parse TCM from device tree

2024-01-31 Thread Mathieu Poirier
On Tue, Jan 30, 2024 at 02:47:07PM -0600, Tanmay Shah wrote: > > On 1/17/24 12:58 PM, Mathieu Poirier wrote: > > Alright, I spent several hours looking at this patchset and the driver as a > > whole. I certainly salute your efforts to heed my advice and make the code > > less > > brittle but

Re: [PATCH v9 3/3] remoteproc: zynqmp: parse TCM from device tree

2024-01-30 Thread Tanmay Shah
On 1/17/24 12:58 PM, Mathieu Poirier wrote: > Alright, I spent several hours looking at this patchset and the driver as a > whole. I certainly salute your efforts to heed my advice and make the code > less > brittle but I'm afraid we are not there. Hi Mathieu, I am back from vacation.

Re: [PATCH v9 3/3] remoteproc: zynqmp: parse TCM from device tree

2024-01-17 Thread Mathieu Poirier
Alright, I spent several hours looking at this patchset and the driver as a whole. I certainly salute your efforts to heed my advice and make the code less brittle but I'm afraid we are not there. See below for a different way to proceed. On Wed, Jan 10, 2024 at 01:35:05PM -0800, Tanmay Shah

[PATCH v9 3/3] remoteproc: zynqmp: parse TCM from device tree

2024-01-10 Thread Tanmay Shah
ZynqMP TCM information was fixed in driver. Now ZynqMP TCM information is available in device-tree. Parse TCM information in driver as per new bindings. Signed-off-by: Tanmay Shah --- Changes in v9: - Introduce new API to request and release core1 TCM power-domains in lockstep mode. This