Re: [PATCHSET] sysfs: implement sysfs_remove()

2013-09-27 Thread Tejun Heo
Hey, On Thu, Sep 26, 2013 at 04:44:33PM -0700, Greg KH wrote: > I seem to remember some issues here as well, probably with scsi devices, > that kept us from doing this in this manner. Can you test this on > removing some scsi devices and see if everything still works properly > with this patchset

Re: [PATCHSET] sysfs: implement sysfs_remove()

2013-09-26 Thread Greg KH
On Thu, Sep 19, 2013 at 12:03:08PM -0500, Eric W. Biederman wrote: > > I am running from memory right now. But the short version is. > > Al Viro has complained about the sysfs removal antics of sysfs, and > I have seen Al get confused and "fix" filesystems that depart too far > from normal files

Re: [PATCHSET] sysfs: implement sysfs_remove()

2013-09-19 Thread Eric W. Biederman
I am running from memory right now. But the short version is. Al Viro has complained about the sysfs removal antics of sysfs, and I have seen Al get confused and "fix" filesystems that depart too far from normal filesystem semantics. I have gone down this path both ways and "rm -rf" semantics a

Re: [PATCHSET] sysfs: implement sysfs_remove()

2013-09-19 Thread Tejun Heo
Hey, Eric. On Thu, Sep 19, 2013 at 05:48:52AM -0500, Eric W. Biederman wrote: > There are two very big problems with this direction. > 1) It violates the principle of least surprise. In particular it messes >up the mental model of people like Al Viro. Which can easily lead to >code break

Re: [PATCHSET] sysfs: implement sysfs_remove()

2013-09-19 Thread Eric W. Biederman
Tejun Heo writes: > Hello, > > Currently, there are multiple variants of internal sysfs removal > functions and the directory removal behavior is a bit weird in that > while it does remove the files contained immediately in the directory > it wouldn't recurse into its subdirectories, even the gro

[PATCHSET] sysfs: implement sysfs_remove()

2013-09-18 Thread Tejun Heo
Hello, Currently, there are multiple variants of internal sysfs removal functions and the directory removal behavior is a bit weird in that while it does remove the files contained immediately in the directory it wouldn't recurse into its subdirectories, even the group ones which belong to the sam